zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-25 20:18:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1934 from cisagov/rjm/csv_export_hot_fix

Browse source 
Fix paginator row overwrite bug
This commit is contained in:
Rachid Mrad 2024-03-25 16:30:37 -04:00 • committed by GitHub
commit aed723b6d2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/utility/csv_export.py
View file

@ -254,6 +254,7 @@ def write_requests_csv(
# Reduce the memory overhead when performing the write operation
paginator = Paginator(all_requests, 1000)
total_body_rows = []
for page_num in paginator.page_range:
page = paginator.page(page_num)
@ -267,10 +268,11 @@ def write_requests_csv(
# It indicates that DomainInformation.domain is None.
logger.error("csv_export -> Error when parsing row, domain was None")
continue
total_body_rows.extend(rows)
if should_write_header:
write_header(writer, columns)
writer.writerows(rows)
writer.writerows(total_body_rows)
def export_data_type_to_csv(csv_file):