changed the order of the permissions checking as the manage domain check was firing before editable check and allowing access

src/registrar/views/utility/mixins.py

@@ -46,6 +46,10 @@ class DomainPermission(PermissionsLoginMixin):
         if pk is None:
             raise ValueError("Primary key is None")
 
+        # test if domain in editable state
+        if not self.in_editable_state(pk):
+            return False
+
         if self.can_access_other_user_domains(pk):
             return True
 
@@ -53,10 +57,6 @@ class DomainPermission(PermissionsLoginMixin):
         if not UserDomainRole.objects.filter(user=self.request.user, domain__id=pk).exists():
             return False
 
-        # test if domain in editable state
-        if not self.in_editable_state(pk):
-            return False
-
         # if we need to check more about the nature of role, do it here.
         return True