mirror of
https://github.com/cisagov/manage.get.gov.git
synced 2025-05-16 17:47:02 +02:00
added mutliple browsers and note for applicant vs analyst
This commit is contained in:
parent
8dc4321191
commit
a67e13b04b
1 changed files with 19 additions and 4 deletions
23
.github/pull_request_template.md
vendored
23
.github/pull_request_template.md
vendored
|
@ -44,7 +44,7 @@ Resolves #00
|
|||
- [ ] Messaged on Slack or in standup to notify the team that a PR is ready for review
|
||||
- [ ] Changes to “how we do things” are documented in READMEs and or onboarding guide
|
||||
|
||||
* Code standards are met:
|
||||
##### Code standards are met (Original Developer)
|
||||
|
||||
- [ ] All new functions and methods are commented using plain language
|
||||
- [ ] Did dependency updates in Pipfile also get changed in requirements.txt?
|
||||
|
@ -64,16 +64,15 @@ Resolves #00
|
|||
|
||||
- [ ] Pulled this branch locally and tested it
|
||||
- [ ] Reviewed this code and left comments
|
||||
- [ ] All new functions and methods are commented using plain language
|
||||
- [ ] Checked that all code is adequately covered by tests
|
||||
- [ ] Made it clear which comments need to be addressed before this work is merged
|
||||
|
||||
* Code standards are met:
|
||||
##### Code standards are met (Code reviewer)
|
||||
|
||||
- [ ] All new functions and methods are commented using plain language
|
||||
- [ ] Did dependency updates in Pipfile also get changed in requirements.txt?
|
||||
- [ ] Interactions with external systems are wrapped in try/except
|
||||
- [ ] Error handling exists for unusual or missing values
|
||||
- [ ] (Rarely needed) Did dependency updates in Pipfile also get changed in requirements.txt?
|
||||
|
||||
#### Validated user-facing changes as a developer
|
||||
|
||||
|
@ -82,6 +81,14 @@ Resolves #00
|
|||
- [ ] Meets all designs and user flows provided by design/product
|
||||
- [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
|
||||
|
||||
- [ ] Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
|
||||
- [ ] Chrome
|
||||
- [ ] Microsoft Edge
|
||||
- [ ] FireFox
|
||||
- [ ] Safari
|
||||
|
||||
- [ ] (Rarely needed) Test as both an analyst and applicant user
|
||||
|
||||
### As a designer reviewer, I have
|
||||
|
||||
#### Verified that the changes match the design intention
|
||||
|
@ -97,6 +104,14 @@ Resolves #00
|
|||
- [ ] Checked keyboard navigability
|
||||
- [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
|
||||
|
||||
- [ ] Tested with multiple browsers (check off which ones were used)
|
||||
- [ ] Chrome
|
||||
- [ ] Microsoft Edge
|
||||
- [ ] FireFox
|
||||
- [ ] Safari
|
||||
|
||||
- [ ] (Rarely needed) Test as both an analyst and applicant user
|
||||
|
||||
## Screenshots
|
||||
|
||||
<!-- If this PR makes visible interface changes, an image of the finished interface can help reviewers
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue