mirror of
https://github.com/cisagov/manage.get.gov.git
synced 2025-07-24 11:38:39 +02:00
updated PR template
This commit is contained in:
parent
a2277ab7b7
commit
a3ab395c30
1 changed files with 86 additions and 9 deletions
95
.github/pull_request_template.md
vendored
95
.github/pull_request_template.md
vendored
|
@ -1,13 +1,90 @@
|
|||
# <!-- Use the title to describe PR changes in the imperative mood --> #
|
||||
# Ticket
|
||||
|
||||
## 🗣 Description ##
|
||||
Resolves #00
|
||||
|
||||
<!-- Describe the "what" of your changes in detail. -->
|
||||
<!-- Please link to any relevant issues. -->
|
||||
## Changes
|
||||
|
||||
## 💭 Motivation and context ##
|
||||
<!-- What was added, updated, or removed in this PR. -->
|
||||
- Change 1
|
||||
- Change 2
|
||||
|
||||
<!-- Why is this change required? -->
|
||||
<!-- What problem does this change solve? How did you solve it? -->
|
||||
<!-- Mention any related issue(s) here using appropriate keywords such -->
|
||||
<!-- as "closes" or "resolves" to auto-close them on merge. -->
|
||||
<!--
|
||||
Please add/remove/edit any of the template below to fit the needs
|
||||
of this specific PR
|
||||
--->
|
||||
|
||||
## Context for reviewers
|
||||
|
||||
<!--Background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. -->
|
||||
|
||||
## Setup
|
||||
|
||||
<!-- Add any steps or code to run in this section to help others run your code.
|
||||
|
||||
Example 1:
|
||||
```sh
|
||||
echo "Code goes here"
|
||||
```
|
||||
|
||||
Example 2: if the PR was to add a new link with a redirect, this section could simply say go to /path/to/start/page. Click the blue link in the <insert location> and see the user is redirected to <propper end location>
|
||||
-->
|
||||
|
||||
## Code Review Verification Steps
|
||||
|
||||
### As the original developer, I have
|
||||
|
||||
#### Satisfied acceptance criteria and met development standards
|
||||
|
||||
- [ ] Met the acceptance criteria, or will meet them in a subsequent PR
|
||||
- [ ] Created/modified automated tests
|
||||
- [ ] Added at least 2 developers as PR reviewers (only 1 will need to approve)
|
||||
- [ ] Messaged on Slack or in standup to notify the team that a PR is ready for review
|
||||
|
||||
#### Validated user-facing changes (if applicable)
|
||||
|
||||
- [ ] Checked keyboard navigability
|
||||
- [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
|
||||
- [ ] Add at least 1 designer as PR reviewer
|
||||
|
||||
### As code reviewer(s), I have
|
||||
|
||||
#### Reviewed, tested, and left feedback about the changes
|
||||
|
||||
- [ ] Pulled this branch locally and tested it
|
||||
- [ ] Reviewed this code and left comments
|
||||
- [ ] Checked that all code is adequately covered by tests
|
||||
- [ ] Made it clear which comments need to be addressed before this work is merged
|
||||
- [ ] Considered marking this as accepted even if there are small changes needed
|
||||
|
||||
#### Validated user-facing changes as a developer
|
||||
|
||||
- [ ] Checked keyboard navigability
|
||||
- [ ] Meets all designs and user flows provided by design/product
|
||||
- [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
|
||||
|
||||
### As a designer reviewer, I have
|
||||
|
||||
#### Verified that the changes match the design intention
|
||||
|
||||
- [ ] Checked in the design translated visually
|
||||
- [ ] Checked behavior
|
||||
- [ ] Checked different states (empty, one, some, error)
|
||||
- [ ] Checked for landmarks, page heading structure, and links
|
||||
- [ ] Tried to break the intended flow
|
||||
|
||||
#### Validated user-facing changes as a designer
|
||||
|
||||
- [ ] Checked keyboard navigability
|
||||
- [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
|
||||
|
||||
## Screenshots
|
||||
|
||||
<!-- If this PR makes visible interface changes, an image of the finished interface can help reviewers
|
||||
and casual observers understand the context of the changes.
|
||||
A before image is optional and can be included at the submitter's discretion.
|
||||
|
||||
Consider using an animated image to show an entire workflow.
|
||||
You may want to use [GIPHY Capture](https://giphy.com/apps/giphycapture) for this! 📸
|
||||
|
||||
_Please frame images to show useful context but also highlight the affected regions._
|
||||
--->
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue