fix linting errors

This commit is contained in:
Neil Martinsen-Burrell 2023-05-24 15:38:26 -05:00
parent 10185553de
commit a277336a06
No known key found for this signature in database
GPG key ID: 6A3C818CC10D0184
3 changed files with 14 additions and 10 deletions

View file

@ -6,7 +6,6 @@ from django.shortcuts import redirect, render
from django.urls import resolve, reverse from django.urls import resolve, reverse
from django.utils.translation import gettext_lazy as _ from django.utils.translation import gettext_lazy as _
from django.views.generic import TemplateView from django.views.generic import TemplateView
from django.views import generic
from django.contrib import messages from django.contrib import messages
from registrar.forms import application_wizard as forms from registrar.forms import application_wizard as forms
@ -494,13 +493,13 @@ class ApplicationWithdrawConfirmation(DomainApplicationPermissionView):
class ApplicationWithdrawn(DomainApplicationPermissionView): class ApplicationWithdrawn(DomainApplicationPermissionView):
# this view renders no template # this view renders no template
template_name = None template_name = ""
def get(self, *args, **kwargs): def get(self, *args, **kwargs):
"""View class that does the actual withdrawing. """View class that does the actual withdrawing.
If user click on withdraw confirm button, this view updates the status to withdraw If user click on withdraw confirm button, this view updates the status
and send back to homepage. to withdraw and send back to homepage.
""" """
application = DomainApplication.objects.get(id=self.kwargs["pk"]) application = DomainApplication.objects.get(id=self.kwargs["pk"])
application.status = "withdrawn" application.status = "withdrawn"

View file

@ -12,10 +12,9 @@ from django.contrib.messages.views import SuccessMessageMixin
from django.db import IntegrityError from django.db import IntegrityError
from django.shortcuts import redirect from django.shortcuts import redirect
from django.urls import reverse from django.urls import reverse
from django.views.generic import DetailView from django.views.generic.edit import FormMixin
from django.views.generic.edit import DeleteView, FormMixin
from registrar.models import Domain, DomainInvitation, User, UserDomainRole from registrar.models import DomainInvitation, User, UserDomainRole
from ..forms import DomainAddUserForm, NameserverFormset, DomainSecurityEmailForm from ..forms import DomainAddUserForm, NameserverFormset, DomainSecurityEmailForm
from ..utility.email import send_templated_email, EmailSendingError from ..utility.email import send_templated_email, EmailSendingError
@ -235,7 +234,11 @@ class DomainAddUserView(DomainPermissionView, FormMixin):
return redirect(self.get_success_url()) return redirect(self.get_success_url())
class DomainInvitationDeleteView(DomainInvitationPermissionDeleteView): class DomainInvitationDeleteView(
DomainInvitationPermissionDeleteView, SuccessMessageMixin
):
object: DomainInvitation # workaround for type mismatch in DeleteView
def get_success_url(self): def get_success_url(self):
return reverse("domain-users", kwargs={"pk": self.object.domain.id}) return reverse("domain-users", kwargs={"pk": self.object.domain.id})

View file

@ -17,7 +17,8 @@ class DomainPermissionView(DomainPermission, DetailView, abc.ABC):
"""Abstract base view for domains that enforces permissions. """Abstract base view for domains that enforces permissions.
This abstract view cannot be instantiated. Actual views must specify `template_name`. This abstract view cannot be instantiated. Actual views must specify
`template_name`.
""" """
# DetailView property for what model this is viewing # DetailView property for what model this is viewing
@ -36,7 +37,8 @@ class DomainApplicationPermissionView(DomainApplicationPermission, DetailView, a
"""Abstract base view for domain applications that enforces permissions """Abstract base view for domain applications that enforces permissions
This abstract view cannot be instantiated. Actual views must specify `template_name`. This abstract view cannot be instantiated. Actual views must specify
`template_name`.
""" """
# DetailView property for what model this is viewing # DetailView property for what model this is viewing