zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-22 10:46:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

lint

Browse source
This commit is contained in:
zandercymatics 2024-09-13 14:29:28 -06:00
parent 8d58b38900
commit a03769350a
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/registrar/tests/test_views_portfolio.py
View file

@ -849,7 +849,7 @@ class TestPortfolio(WebTest):
user=self.user, user=self.user,
portfolio=self.portfolio, portfolio=self.portfolio,
roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER], roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
additional_permissions=[UserPortfolioPermissionChoices.EDIT_REQUESTS] additional_permissions=[UserPortfolioPermissionChoices.EDIT_REQUESTS],
) )
# Create a domain request with status WITHDRAWN # Create a domain request with status WITHDRAWN
@ -882,7 +882,7 @@ class TestPortfolio(WebTest):
user=self.user, user=self.user,
portfolio=self.portfolio, portfolio=self.portfolio,
roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER], roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
additional_permissions=[] additional_permissions=[],
) )
# Create a domain request with status STARTED # Create a domain request with status STARTED
@ -915,7 +915,7 @@ class TestPortfolio(WebTest):
user=self.user, user=self.user,
portfolio=self.portfolio, portfolio=self.portfolio,
roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER], roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
additional_permissions=[UserPortfolioPermissionChoices.EDIT_REQUESTS] additional_permissions=[UserPortfolioPermissionChoices.EDIT_REQUESTS],
) )
# Create another user and a domain request # Create another user and a domain request
@ -936,4 +936,4 @@ class TestPortfolio(WebTest):
self.assertEqual(response.status_code, 403) self.assertEqual(response.status_code, 403)
# Check that the domain request still exists # Check that the domain request still exists
self.assertTrue(DomainRequest.objects.filter(pk=domain_request.pk).exists()) self.assertTrue(DomainRequest.objects.filter(pk=domain_request.pk).exists())

2
src/registrar/views/domain_request.py
View file

@ -796,7 +796,7 @@ class DomainRequestDeleteView(DomainRequestPermissionDeleteView):
if status not in valid_statuses: if status not in valid_statuses:
return False return False
# Portfolio users cannot delete their requests if they aren't permissioned to do so # Portfolio users cannot delete their requests if they aren't permissioned to do so
if self.request.user.is_org_user(self.request): if self.request.user.is_org_user(self.request):
portfolio = self.request.session.get("portfolio") portfolio = self.request.session.get("portfolio")
if not self.request.user.has_edit_request_portfolio_permission(portfolio): if not self.request.user.has_edit_request_portfolio_permission(portfolio):