From 9e65d687acbbbca97eeaa6dbb8fd8129ccd7fc11 Mon Sep 17 00:00:00 2001
From: zandercymatics <141044360+zandercymatics@users.noreply.github.com>
Date: Thu, 21 Dec 2023 10:06:45 -0700
Subject: [PATCH] Limit email chatter in fixtures

---
 src/registrar/fixtures_applications.py     |  5 ++++-
 src/registrar/models/domain_application.py | 14 ++++++++++----
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/registrar/fixtures_applications.py b/src/registrar/fixtures_applications.py
index ad3ae0820..ae82ddd8b 100644
--- a/src/registrar/fixtures_applications.py
+++ b/src/registrar/fixtures_applications.py
@@ -218,5 +218,8 @@ class DomainFixture(DomainApplicationFixture):
                 creator=user, status=DomainApplication.ApplicationStatus.IN_REVIEW
             ).last()
             logger.debug(f"Approving {application} for {user}")
-            application.approve()
+
+            # We don't want fixtures sending out real emails to
+            # fake email addresses, so we just skip that and log it instead
+            application.approve(do_fake_send_email=True)
             application.save()
diff --git a/src/registrar/models/domain_application.py b/src/registrar/models/domain_application.py
index 303f0cd22..495b7e171 100644
--- a/src/registrar/models/domain_application.py
+++ b/src/registrar/models/domain_application.py
@@ -561,8 +561,8 @@ class DomainApplication(TimeStampedModel):
             return not self.approved_domain.is_active()
         return True
 
-    def _send_status_update_email(self, new_status, email_template, email_template_subject):
-        """Send a atatus update email to the submitter.
+    def _send_status_update_email(self, new_status, email_template, email_template_subject, do_fake_send_email=False):
+        """Send a status update email to the submitter.
 
         The email goes to the email address that the submitter gave as their
         contact information. If there is not submitter information, then do
@@ -571,7 +571,12 @@ class DomainApplication(TimeStampedModel):
 
         if self.submitter is None or self.submitter.email is None:
             logger.warning(f"Cannot send {new_status} email, no submitter email address.")
-            return
+            return None
+
+        if do_fake_send_email:
+            logger.info(f"Email was not sent. Would send {new_status} to email: {self.submitter.email}")
+            return None
+
         try:
             send_templated_email(
                 email_template,
@@ -651,7 +656,7 @@ class DomainApplication(TimeStampedModel):
         ],
         target=ApplicationStatus.APPROVED,
     )
-    def approve(self):
+    def approve(self, do_fake_send_email=False):
         """Approve an application that has been submitted.
 
         This has substantial side-effects because it creates another database
@@ -680,6 +685,7 @@ class DomainApplication(TimeStampedModel):
             "application approved",
             "emails/status_change_approved.txt",
             "emails/status_change_approved_subject.txt",
+            do_fake_send_email,
         )
 
     @transition(