From 9c8ed1682bcc78e3f239b765b88b20020878f140 Mon Sep 17 00:00:00 2001 From: Rachid Mrad Date: Wed, 13 Dec 2023 15:41:18 -0500 Subject: [PATCH] linter --- src/djangooidc/backends.py | 2 +- src/registrar/tests/common.py | 4 ++-- src/registrar/tests/test_admin.py | 4 ++-- src/registrar/tests/test_models.py | 10 +++++----- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/djangooidc/backends.py b/src/djangooidc/backends.py index 7a192e4a5..b0e6417db 100644 --- a/src/djangooidc/backends.py +++ b/src/djangooidc/backends.py @@ -67,7 +67,7 @@ class OpenIdConnectBackend(ModelBackend): def update_existing_user(self, user, kwargs): """Update other fields without overwriting first_name and last_name. Overwrite first_name and last_name if not empty string""" - + for key, value in kwargs.items(): # Check if the key is not first_name or last_name or value is not empty string if key not in ["first_name", "last_name"] or value: diff --git a/src/registrar/tests/common.py b/src/registrar/tests/common.py index 443c05ee3..ec09b45d0 100644 --- a/src/registrar/tests/common.py +++ b/src/registrar/tests/common.py @@ -406,8 +406,8 @@ def mock_user(): """A simple user.""" user_kwargs = dict( id=4, - first_name="Rachid", - last_name="Mrad", + first_name="Jeff", + last_name="Lebowski", ) mock_user, _ = User.objects.get_or_create(**user_kwargs) return mock_user diff --git a/src/registrar/tests/test_admin.py b/src/registrar/tests/test_admin.py index 82af3573c..8cca67d1e 100644 --- a/src/registrar/tests/test_admin.py +++ b/src/registrar/tests/test_admin.py @@ -1021,7 +1021,7 @@ class ListHeaderAdminTest(TestCase): # Set the GET parameters for testing request.GET = { "status": "started", - "investigator": "Rachid Mrad", + "investigator": "Jeff Lebowski", "q": "search_value", } # Call the get_filters method @@ -1032,7 +1032,7 @@ class ListHeaderAdminTest(TestCase): filters, [ {"parameter_name": "status", "parameter_value": "started"}, - {"parameter_name": "investigator", "parameter_value": "Rachid Mrad"}, + {"parameter_name": "investigator", "parameter_value": "Jeff Lebowski"}, ], ) diff --git a/src/registrar/tests/test_models.py b/src/registrar/tests/test_models.py index dfab4f9a3..d9090c287 100644 --- a/src/registrar/tests/test_models.py +++ b/src/registrar/tests/test_models.py @@ -659,7 +659,7 @@ class TestUser(TestCase): class TestContact(TestCase): def setUp(self): self.email = "mayor@igorville.gov" - self.user, _ = User.objects.get_or_create(email=self.email, first_name="Rachid", last_name="Mrad") + self.user, _ = User.objects.get_or_create(email=self.email, first_name="Jeff", last_name="Lebowski") self.contact, _ = Contact.objects.get_or_create(user=self.user) def tearDown(self): @@ -670,10 +670,10 @@ class TestContact(TestCase): def test_saving_contact_updates_user_first_last_names(self): """When a contact is updated, we propagate the changes to the linked user if it exists.""" # User and Contact are created and linked as expected - self.assertEqual(self.contact.first_name, "Rachid") - self.assertEqual(self.contact.last_name, "Mrad") - self.assertEqual(self.user.first_name, "Rachid") - self.assertEqual(self.user.last_name, "Mrad") + self.assertEqual(self.contact.first_name, "Jeff") + self.assertEqual(self.contact.last_name, "Lebowski") + self.assertEqual(self.user.first_name, "Jeff") + self.assertEqual(self.user.last_name, "Lebowski") self.contact.first_name = "Joey" self.contact.last_name = "Baloney"