zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-17 18:09:25 +02:00
Code Issues Projects Releases Packages Wiki Activity

Further simplification

Browse source
This commit is contained in:
zandercymatics 2024-06-21 13:35:16 -06:00
parent c84966b059
commit 9b86fa43c4
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
3 changed files with 9 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/registrar/models/domain_request.py
View file

@ -597,10 +597,8 @@ class DomainRequest(TimeStampedModel):
def save(self, *args, **kwargs):
"""Save override for custom properties"""
self.sync_organization_type()
self.sync_yes_no_form_fields()
self.sync_action_needed_reason_email()
super().save(*args, **kwargs)
@ -611,13 +609,6 @@ class DomainRequest(TimeStampedModel):
# Update the cached values after saving
self._cache_status_and_action_needed_reason()
def sync_action_needed_reason_email(self):
"""If no action_needed_reason_email is defined, add a default one"""
# Change this in #1901. Add a check on "not self.action_needed_reason_email"
if self.action_needed_reason:
text = self.get_action_needed_reason_default_email_text(self.action_needed_reason)
self.action_needed_reason_email = text.get("email_body_text")
def sync_action_needed_reason(self):
"""Checks if we need to send another action needed email"""
was_already_action_needed = self._cached_status == self.DomainRequestStatus.ACTION_NEEDED
@ -851,7 +842,6 @@ class DomainRequest(TimeStampedModel):
# Unknown and other are default cases - do nothing
can_send_email = False
# TODO - replace this logic with self.action_needed_reason_email in #1901.
# Assumes that the template name matches the action needed reason if nothing is specified.
# This is so you can override if you need, or have this taken care of for you.
if not email_template_name and not email_template_subject_name: