From 9931fcc4d3a4c7ce924f03b5f86649926a2ad1a1 Mon Sep 17 00:00:00 2001 From: zandercymatics <141044360+zandercymatics@users.noreply.github.com> Date: Thu, 18 Apr 2024 12:36:11 -0600 Subject: [PATCH] Fix tests / lint --- src/registrar/forms/domain_request_wizard.py | 5 ++--- src/registrar/models/domain_request.py | 6 ++---- src/registrar/tests/test_admin.py | 2 ++ 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/registrar/forms/domain_request_wizard.py b/src/registrar/forms/domain_request_wizard.py index 95d1f9a4a..752ad7f35 100644 --- a/src/registrar/forms/domain_request_wizard.py +++ b/src/registrar/forms/domain_request_wizard.py @@ -680,9 +680,8 @@ class AdditionalDetailsForm(BaseDeletableRegistrarForm): ) ], error_messages={ - "required": ( - "Provide additional details you’d like us to know. " - "If you have nothing to add, select “No.”" + "required": ( + "Provide additional details you’d like us to know. " "If you have nothing to add, select “No.”" ) }, ) diff --git a/src/registrar/models/domain_request.py b/src/registrar/models/domain_request.py index 0b6e9a2b4..32c0ec0c6 100644 --- a/src/registrar/models/domain_request.py +++ b/src/registrar/models/domain_request.py @@ -738,11 +738,9 @@ class DomainRequest(TimeStampedModel): self.has_cisa_representative = ( self.cisa_representative_email != "" and self.cisa_representative_email is not None ) - + if self.anything_else is not None: - self.has_anything_else_text = ( - self.anything_else != "" and self.anything_else is not None - ) + self.has_anything_else_text = self.anything_else != "" and self.anything_else is not None def __str__(self): try: diff --git a/src/registrar/tests/test_admin.py b/src/registrar/tests/test_admin.py index abc6b76aa..3293fc47c 100644 --- a/src/registrar/tests/test_admin.py +++ b/src/registrar/tests/test_admin.py @@ -1883,7 +1883,9 @@ class TestDomainRequestAdmin(MockEppLib): "purpose", "no_other_contacts_rationale", "anything_else", + "has_anything_else_text", "cisa_representative_email", + "has_cisa_representative", "is_policy_acknowledged", "submission_date", "notes",