zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-22 10:46:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

commented js

Browse source
This commit is contained in:
David Kennedy 2024-10-18 13:09:18 -04:00
parent 3b74793d94
commit 96c77cd476
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/registrar/assets/js/get-gov.js
View file

@ -1910,22 +1910,22 @@ class MembersTable extends LoadTableBase {
/** /**
* Helper function which takes last_active and returns display value and sort value * Helper function which takes last_active and returns display value and sort value
* @param {*} last_active * @param {*} last_active - UTC date, or strings "Invited" or "Invalid date"
* @returns * @returns
*/ */
handleLastActive(last_active) { handleLastActive(last_active) {
let last_active_display = ''; let last_active_display = '';
let last_active_sort_value = -1; let last_active_sort_value = -1; // sort by default as numeric value to sort with dates
const invited = 'Invited'; // Assuming "invited" is a constant string const invited = 'Invited';
const invalid_date = 'Invalid date'; // Assuming "invalid_date" is a constant string const invalid_date = 'Invalid date';
const options = { year: 'numeric', month: 'long', day: 'numeric' }; // Format options for date const options = { year: 'numeric', month: 'long', day: 'numeric' }; // Format options for date
// Check if last_active is valid before proceeding // Check if last_active is not null
if (last_active) { if (last_active) {
if (last_active === invited) { if (last_active === invited) {
last_active_display = invited; last_active_display = invited;
last_active_sort_value = 0; last_active_sort_value = 0; // sort as numeric value
} else if (last_active === invalid_date) { } else if (last_active === invalid_date) {
last_active_display = invalid_date; last_active_display = invalid_date;
} else { } else {
@ -1934,11 +1934,11 @@ class MembersTable extends LoadTableBase {
try { try {
if (!isNaN(parsedDate.getTime())) { // Check if the date is valid if (!isNaN(parsedDate.getTime())) { // Check if the date is valid
last_active_display = parsedDate.toLocaleDateString('en-US', options); last_active_display = parsedDate.toLocaleDateString('en-US', options);
last_active_sort_value = parsedDate.getTime(); // For sorting purposes last_active_sort_value = parsedDate.getTime(); // sort as numeric value, seconds since 1970
} else { } else {
throw new Error(invalid_date); // Throw an error to catch in catch block throw new Error(invalid_date); // Throw an error to catch in catch block
} }
} catch (e) { } catch (e) { // catch invalid values and treat as 'Invalid date'
console.error(`Error parsing date: ${last_active}. Error: ${e}`); console.error(`Error parsing date: ${last_active}. Error: ${e}`);
last_active_display = invalid_date; last_active_display = invalid_date;
} }