zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-31 01:33:56 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix test cases + logging fixes

Browse source
This commit is contained in:
zandercymatics 2023-11-08 16:32:02 -07:00
parent 1ad40cc709
commit 9409b3f41c
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
5 changed files with 20 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/registrar/management/commands/utility/extra_transition_domain_helper.py
View file

@ -185,11 +185,8 @@ class LoadExtraTransitionDomain:
)
# Check if the instance has changed before saving
#if updated_transition_domain.__dict__ != transition_domain.__dict__:
updated_transition_domain.save()
updated_transition_domains.append(updated_transition_domain)
logger.info(
f"{TerminalColors.OKCYAN}"
f"Successfully updated {domain_name}"
@ -208,17 +205,16 @@ class LoadExtraTransitionDomain:
)
failed_transition_domains.append(domain_name)
if self.debug:
# Display misc errors (not associated to a domain)
self.parse_logs.display_logs_by_domain_name(None)
failed_count = len(failed_transition_domains)
if failed_count == 0:
TerminalHelper.print_conditional(self.debug, f"{TerminalHelper.array_as_string(updated_transition_domains)}")
if self.debug:
for domain in updated_transition_domains:
logger.debug(domain.display_transition_domain())
logger.info(
f"""{TerminalColors.OKGREEN}
============= FINISHED ===============
Updated {len(updated_transition_domains)} transition domain entries:
{[domain for domain in updated_transition_domains]}
{TerminalColors.ENDC}
"""
)
@ -228,18 +224,20 @@ class LoadExtraTransitionDomain:
logger.error(
f"""{TerminalColors.FAIL}
============= FINISHED WITH ERRORS ===============
Updated {len(updated_transition_domains)} transition domain entries,
Failed to update {failed_count} transition domain entries
Updated {len(updated_transition_domains)} transition domain entries:
{[domain for domain in updated_transition_domains]}
Failed to update {failed_count} transition domain entries:
{[domain for domain in failed_transition_domains]}
{TerminalColors.ENDC}
"""
)
# DATA INTEGRITY CHECK
# Make sure every Transition Domain got updated
total_transition_domains = TransitionDomain.objects.all().count()
total_transition_domains = len(updated_transition_domains)
total_updates_made = TransitionDomain.objects.all().count()
if total_transition_domains != total_updates_made:
logger.error(f"""{TerminalColors.Fail}
logger.error(f"""{TerminalColors.FAIL}
WARNING: something went wrong processing domain information data.
Total Transition Domains expecting a data update: {total_transition_domains}