zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-06 01:35:22 +02:00
Code Issues Projects Releases Packages Wiki Activity

Refactor spacing

Browse source
This commit is contained in:
Erin Song 2024-10-03 14:46:13 -07:00
parent ff155fd4e7
commit 93ee3b0b8f
No known key found for this signature in database
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
.github/pull_request_template.md vendored
View file

@ -43,7 +43,8 @@ Resolves #001
- [ ] Update documentation in READMEs and/or onboarding guide
#### Ensured code standards are met (Original Developer)
<!-- Write N/A if the below code standards are not applicable to your PR -->
N/A - no external systems or errors, this is just docs refactoring.
- [ ] Interactions with external systems are wrapped in try/except
- [ ] Error handling exists for unusual or missing values
@ -58,7 +59,7 @@ Resolves #001
#### Reviewed, tested, and left feedback about the changes
- [ ] Pulled this branch locally and tested it
- [ ] Verified code meets code standards and comments if any standards above are not satisfied
- [ ] Verified code meets above code standards and user-facing checks. Addresses any checks that are not satisfied
- [ ] Reviewed this code and left comments. Indicate if comments must be addressed before code is merged.
- [ ] Checked that all code is adequately covered by tests
- [ ] If any model was updated to modify/add/delete columns, verified migrations can be run with `makemigrations`.
@ -85,7 +86,7 @@ Resolves #001
#### Validated user-facing changes as a designer
- [ ] Checked keyboard navigability
- [ ] Checked different states (empty, one, some, error)
- [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
- [ ] Tested with multiple browsers (check off which ones were used)