From 934d06dfb5a56ef93fdc03df4df9a41bf51de107 Mon Sep 17 00:00:00 2001 From: zandercymatics <141044360+zandercymatics@users.noreply.github.com> Date: Fri, 25 Oct 2024 10:52:22 -0600 Subject: [PATCH] lint and fix existing unit tests --- src/registrar/tests/test_views_portfolio.py | 3 --- src/registrar/tests/test_views_request.py | 2 -- src/registrar/views/domain_request.py | 2 +- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/registrar/tests/test_views_portfolio.py b/src/registrar/tests/test_views_portfolio.py index d770dd677..6bf6ad783 100644 --- a/src/registrar/tests/test_views_portfolio.py +++ b/src/registrar/tests/test_views_portfolio.py @@ -1573,9 +1573,6 @@ class TestRequestingEntity(WebTest): def test_requesting_entity_page_errors(self): """Tests that we get the expected form errors on requesting entity""" domain_request = completed_domain_request(user=self.user, portfolio=self.portfolio) - UserPortfolioPermission.objects.create( - portfolio=self.portfolio, user=self.user, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN] - ) response = self.app.get(reverse("edit-domain-request", kwargs={"id": domain_request.pk})).follow() form = response.forms[0] session_id = self.app.cookies[settings.SESSION_COOKIE_NAME] diff --git a/src/registrar/tests/test_views_request.py b/src/registrar/tests/test_views_request.py index 17e6bcbe6..73e538df3 100644 --- a/src/registrar/tests/test_views_request.py +++ b/src/registrar/tests/test_views_request.py @@ -2887,8 +2887,6 @@ class DomainRequestTestDifferentStatuses(TestWithUser, WebTest): detail_page = self.app.get(f"/domain-request/{domain_request.id}") self.assertContains(detail_page, "city.gov") self.assertContains(detail_page, "city1.gov") - self.assertContains(detail_page, "Chief Tester") - self.assertContains(detail_page, "testy@town.com") self.assertContains(detail_page, "Status:") # click the "Withdraw request" button mock_client = MockSESClient() diff --git a/src/registrar/views/domain_request.py b/src/registrar/views/domain_request.py index bdb496c9e..d39833fab 100644 --- a/src/registrar/views/domain_request.py +++ b/src/registrar/views/domain_request.py @@ -600,7 +600,7 @@ class RequestingEntity(DomainRequestWizard): sub_organization = cleaned_data.get("sub_organization") requested_suborganization = cleaned_data.get("requested_suborganization") - # If no suborganization presently exists but the user filled out + # If no suborganization presently exists but the user filled out # org information then create a suborg automatically. if is_suborganization and (sub_organization or requested_suborganization): # Cleanup the organization name field, as this isn't for suborganizations.