zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-12 20:49:41 +02:00
Code Issues Projects Releases Packages Wiki Activity

fixes related to PR review comments

Browse source
This commit is contained in:
David Kennedy 2024-10-16 12:12:16 -04:00
parent 445af256b6
commit 928fe01a6c
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/registrar/assets/js/get-gov.js
View file

@ -1926,6 +1926,8 @@ class MembersTable extends LoadTableBase {
const memberList = document.querySelector('.members__table tbody'); const memberList = document.querySelector('.members__table tbody');
memberList.innerHTML = ''; memberList.innerHTML = '';
const invited = 'Invited';
data.members.forEach(member => { data.members.forEach(member => {
const member_name = member.name; const member_name = member.name;
const member_display = member.member_display; const member_display = member.member_display;
@ -1937,7 +1939,7 @@ class MembersTable extends LoadTableBase {
let last_active_sort_value = ''; let last_active_sort_value = '';
// Handle 'Invited' or null/empty values differently from valid dates // Handle 'Invited' or null/empty values differently from valid dates
if (last_active && last_active !== 'Invited') { if (last_active && last_active !== invited) {
try { try {
// Try to parse the last_active as a valid date // Try to parse the last_active as a valid date
last_active = new Date(last_active); last_active = new Date(last_active);
@ -1953,9 +1955,9 @@ class MembersTable extends LoadTableBase {
} }
} else { } else {
// Handle 'Invited' or null // Handle 'Invited' or null
last_active = 'Invited'; last_active = invited;
last_active_formatted = 'Invited'; last_active_formatted = invited;
last_active_sort_value = 'Invited'; // Keep 'Invited' as a sortable string last_active_sort_value = invited; // Keep 'Invited' as a sortable string
} }
const action_url = member.action_url; const action_url = member.action_url;

4
src/registrar/templates/portfolio_member.html
View file

@ -119,9 +119,9 @@
</address> </address>
{% if portfolio_permission %} {% if portfolio_permission %}
{% include "includes/summary_item.html" with title='Member access and permissions' permissions=True value=portfolio_permission member_has_view_all_requests_portfolio_permission=member_has_view_all_requests_portfolio_permission member_has_edit_request_portfolio_permission=member_has_edit_request_portfolio_permission member_has_view_members_portfolio_permission=member_has_view_members_portfolio_permission member_has_edit_members_portfolio_permission=member_has_edit_members_portfolio_permission edit_link=edit_url editable=has_edit_members_portfolio_permission %} {% include "includes/summary_item.html" with title='Member access and permissions' permissions=True value=portfolio_permission edit_link=edit_url editable=has_edit_members_portfolio_permission %}
{% elif portfolio_invitation %} {% elif portfolio_invitation %}
{% include "includes/summary_item.html" with title='Member access and permissions' permissions=True value=portfolio_invitation member_has_view_all_requests_portfolio_permission=member_has_view_all_requests_portfolio_permission member_has_edit_request_portfolio_permission=member_has_edit_request_portfolio_permission member_has_view_members_portfolio_permission=member_has_view_members_portfolio_permission member_has_edit_members_portfolio_permission=member_has_edit_members_portfolio_permission edit_link=edit_url editable=has_edit_members_portfolio_permission %} {% include "includes/summary_item.html" with title='Member access and permissions' permissions=True value=portfolio_invitation edit_link=edit_url editable=has_edit_members_portfolio_permission %}
{% endif %} {% endif %}
{% comment %}view_button is passed below as true in all cases. This is because manage_button logic will trump view_button logic; ie. if manage_button is true, view_button will never be looked at{% endcomment %} {% comment %}view_button is passed below as true in all cases. This is because manage_button logic will trump view_button logic; ie. if manage_button is true, view_button will never be looked at{% endcomment %}