zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-15 09:07:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup

Browse source
This commit is contained in:
zandercymatics 2024-04-19 15:47:03 -06:00
parent a047380b59
commit 8b27c44b89
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
1 changed files with 17 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

40
src/registrar/models/user.py
View file

@ -113,10 +113,13 @@ class User(AbstractUser):
def has_contact_info(self): def has_contact_info(self):
return bool(self.contact.title or self.contact.email or self.contact.phone) return bool(self.contact.title or self.contact.email or self.contact.phone)
@classmethod @classmethod
def existing_user(cls, uuid): def needs_identity_verification(cls, email, uuid):
existing_user = None """A method used by our oidc classes to test whether a user needs email/uuid verification
or the full identity PII verification"""
# An existing user who is a domain manager of a domain (that is,
# they have an entry in UserDomainRole for their User)
try: try:
existing_user = cls.objects.get(username=uuid) existing_user = cls.objects.get(username=uuid)
if existing_user and UserDomainRole.objects.filter(user=existing_user).exists(): if existing_user and UserDomainRole.objects.filter(user=existing_user).exists():
@ -127,23 +130,20 @@ class User(AbstractUser):
except Exception as err: except Exception as err:
raise err raise err
return True # We can't set the verification type here because the user may not
# always exist at this point. We do it down the line.
@classmethod verification_type = cls.get_verification_type_from_email(email)
def needs_identity_verification(cls, email, uuid):
"""A method used by our oidc classes to test whether a user needs email/uuid verification
or the full identity PII verification"""
# An existing user who is a domain manager of a domain (that is,
# they have an entry in UserDomainRole for their User)
user_exists = cls.existing_user(uuid)
if not user_exists:
return False
# The user needs identity verification if they don't meet # The user needs identity verification if they don't meet
# any special criteria, i.e. we are validating them "regularly" # any special criteria, i.e. we are validating them "regularly"
verification_type = cls.get_verification_type_from_email(email) needs_verification = verification_type == cls.VerificationTypeChoices.REGULAR
return verification_type == cls.VerificationTypeChoices.REGULAR return needs_verification
def set_user_verification_type(self):
# Would need to check audit log
retrieved = DomainInvitation.DomainInvitationStatus.RETRIEVED
verification_type = self.get_verification_type_from_email(self.email, invitation_status=retrieved)
self.verification_type = verification_type
@classmethod @classmethod
def get_verification_type_from_email(cls, email, invitation_status=DomainInvitation.DomainInvitationStatus.INVITED): def get_verification_type_from_email(cls, email, invitation_status=DomainInvitation.DomainInvitationStatus.INVITED):
@ -167,12 +167,6 @@ class User(AbstractUser):
return verification_type return verification_type
def set_user_verification_type(self):
# Would need to check audit log
retrieved = DomainInvitation.DomainInvitationStatus.RETRIEVED
verification_type = self.get_verification_type_from_email(self.email, invitation_status=retrieved)
self.verification_type = verification_type
def check_domain_invitations_on_login(self): def check_domain_invitations_on_login(self):
"""When a user first arrives on the site, we need to retrieve any domain """When a user first arrives on the site, we need to retrieve any domain
invitations that match their email address.""" invitations that match their email address."""