From 89c2e4543a3d37b64306b44829c13815e06f305f Mon Sep 17 00:00:00 2001 From: zandercymatics <141044360+zandercymatics@users.noreply.github.com> Date: Tue, 27 Aug 2024 12:27:35 -0600 Subject: [PATCH] Update src/registrar/models/user.py Co-authored-by: Matt-Spence --- src/registrar/models/user.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/registrar/models/user.py b/src/registrar/models/user.py index 03d11e5bd..a7ea1e14a 100644 --- a/src/registrar/models/user.py +++ b/src/registrar/models/user.py @@ -206,12 +206,11 @@ class User(AbstractUser): if not portfolio: return False - portfolio_perms = self.portfolio_permissions.filter(portfolio=portfolio, user=self).first() - if not portfolio_perms: + user_portfolio_perms = self.portfolio_permissions.filter(portfolio=portfolio, user=self).first() + if not user_portfolio_perms: return False - portfolio_permissions = portfolio_perms._get_portfolio_permissions() - return portfolio_permission in portfolio_permissions + return portfolio_permission in user_portfolio_perms._get_portfolio_permissions() def has_base_portfolio_permission(self, portfolio): return self._has_portfolio_permission(portfolio, UserPortfolioPermissionChoices.VIEW_PORTFOLIO)