mirror of
https://github.com/cisagov/manage.get.gov.git
synced 2025-08-04 17:01:56 +02:00
Resolve merge conflict issues
This commit is contained in:
commit
88cb4fc78a
13 changed files with 386 additions and 36 deletions
|
@ -3,7 +3,7 @@ import ipaddress
|
|||
|
||||
from datetime import date
|
||||
from string import digits
|
||||
from django_fsm import FSMField, transition # type: ignore
|
||||
from django_fsm import FSMField, transition, TransitionNotAllowed # type: ignore
|
||||
|
||||
from django.db import models
|
||||
from typing import Any
|
||||
|
@ -739,11 +739,6 @@ class Domain(TimeStampedModel, DomainHelper):
|
|||
"""
|
||||
return self.state == self.State.READY
|
||||
|
||||
def delete_request(self):
|
||||
"""Delete from host. Possibly a duplicate of _delete_host?"""
|
||||
# TODO fix in ticket #901
|
||||
pass
|
||||
|
||||
def transfer(self):
|
||||
"""Going somewhere. Not implemented."""
|
||||
raise NotImplementedError()
|
||||
|
@ -788,7 +783,7 @@ class Domain(TimeStampedModel, DomainHelper):
|
|||
"""This domain should be deleted from the registry
|
||||
may raises RegistryError, should be caught or handled correctly by caller"""
|
||||
request = commands.DeleteDomain(name=self.name)
|
||||
registry.send(request)
|
||||
registry.send(request, cleaned=True)
|
||||
|
||||
def __str__(self) -> str:
|
||||
return self.name
|
||||
|
@ -945,6 +940,33 @@ class Domain(TimeStampedModel, DomainHelper):
|
|||
self._delete_domain()
|
||||
# TODO - delete ticket any additional error handling here
|
||||
|
||||
@transition(
|
||||
field="state", source=[State.ON_HOLD, State.DNS_NEEDED], target=State.DELETED
|
||||
)
|
||||
def deletedInEpp(self):
|
||||
"""Domain is deleted in epp but is saved in our database.
|
||||
Error handling should be provided by the caller."""
|
||||
# While we want to log errors, we want to preserve
|
||||
# that information when this function is called.
|
||||
# Human-readable errors are introduced at the admin.py level,
|
||||
# as doing everything here would reduce reliablity.
|
||||
try:
|
||||
logger.info("deletedInEpp()-> inside _delete_domain")
|
||||
self._delete_domain()
|
||||
except RegistryError as err:
|
||||
logger.error(f"Could not delete domain. Registry returned error: {err}")
|
||||
raise err
|
||||
except TransitionNotAllowed as err:
|
||||
logger.error("Could not delete domain. FSM failure: {err}")
|
||||
raise err
|
||||
except Exception as err:
|
||||
logger.error(
|
||||
f"Could not delete domain. An unspecified error occured: {err}"
|
||||
)
|
||||
raise err
|
||||
else:
|
||||
self._invalidate_cache()
|
||||
|
||||
# def is_dns_needed(self):
|
||||
# """Commented out and kept in the codebase
|
||||
# as this call should be made, but adds
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue