zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-22 18:56:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

fixed form submission and error logging

Browse source
This commit is contained in:
David Kennedy 2023-10-03 16:18:30 -04:00
parent 35a455f6fa
commit 84cc92cb0a
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/registrar/views/domain.py
View file

@ -336,7 +336,7 @@ class DomainDsdataView(DomainPermissionView, FormMixin):
for form in formset: for form in formset:
try: try:
if 'delete' in form.cleaned_data and form.cleaned_data['delete'] == True: if 'delete' not in form.cleaned_data or form.cleaned_data['delete'] == False:
dsrecord = { dsrecord = {
"keyTag": form.cleaned_data["key_tag"], "keyTag": form.cleaned_data["key_tag"],
"alg": form.cleaned_data["algorithm"], "alg": form.cleaned_data["algorithm"],
@ -352,7 +352,8 @@ class DomainDsdataView(DomainPermissionView, FormMixin):
domain.dnssecdata = dnssecdata domain.dnssecdata = dnssecdata
except RegistryError as err: except RegistryError as err:
errmsg = "Error updating DNSSEC data in the registry." errmsg = "Error updating DNSSEC data in the registry."
logger.error(f"{{ errmsg }}: {{ err }}") logger.error(errmsg)
logger.error(err)
messages.error( messages.error(
self.request, errmsg self.request, errmsg
) )
@ -427,7 +428,7 @@ class DomainKeydataView(DomainPermissionView, FormMixin):
for form in formset: for form in formset:
try: try:
if 'delete' in form.cleaned_data and form.cleaned_data['delete'] == True: if 'delete' not in form.cleaned_data or form.cleaned_data['delete'] == False:
keyrecord = { keyrecord = {
"flags": form.cleaned_data["flag"], "flags": form.cleaned_data["flag"],
"protocol": form.cleaned_data["protocol"], "protocol": form.cleaned_data["protocol"],
@ -443,7 +444,8 @@ class DomainKeydataView(DomainPermissionView, FormMixin):
domain.dnssecdata = dnssecdata domain.dnssecdata = dnssecdata
except RegistryError as err: except RegistryError as err:
errmsg = "Error updating DNSSEC data in the registry." errmsg = "Error updating DNSSEC data in the registry."
logger.error(f"{{ errmsg }}: {{ err }}") logger.error(errmsg)
logger.error(err)
messages.error( messages.error(
self.request, errmsg self.request, errmsg
) )