Linting

src/registrar/management/commands/transfer_transition_domains_to_domains.py

@@ -371,11 +371,7 @@ class Command(BaseCommand):
         # Create a new one
         if contact_count == 0:
             contact = Contact(
-                first_name=first_name,
+                first_name=first_name, middle_name=middle_name, last_name=last_name, email=email, phone=phone
-                middle_name=middle_name,
-                last_name=last_name,
-                email=email,
-                phone=phone
             )
             contact.save()
         elif contact_count == 1:
@@ -427,7 +423,7 @@ class Command(BaseCommand):
             "domain": domain,
             "organization_name": transition_domain.organization_name,
             "creator": default_creator,
-            "authorizing_official": contact
+            "authorizing_official": contact,
         }
 
         if valid_org_type:

src/registrar/management/commands/utility/extra_transition_domain_helper.py

@@ -287,10 +287,7 @@ class LoadExtraTransitionDomain:
 
     def log_add_or_changed_values(self, file_type, values_to_check, domain_name):
         for field_name, value in values_to_check:
-            str_exists = (
+            str_exists = value is not None and value.strip() != ""
-                value is not None
-                and value.strip() != ""
-            )
             # Logs if we either added to this property,
             # or modified it.
             self._add_or_change_message(
@@ -331,11 +328,7 @@ class LoadExtraTransitionDomain:
             ("email", transition_domain.email),
             ("phone", transition_domain.phone),
         ]
-        self.log_add_or_changed_values(
+        self.log_add_or_changed_values(EnumFilenames.AUTHORITY_ADHOC, changed_fields, domain_name)
-            EnumFilenames.AUTHORITY_ADHOC,
-            changed_fields,
-            domain_name
-        )
 
         return transition_domain
 

src/registrar/models/transition_domain.py

@@ -1,6 +1,7 @@
 from django.db import models
 from .utility.time_stamped_model import TimeStampedModel
 
+
 class StatusChoices(models.TextChoices):
     READY = "ready", "Ready"
     ON_HOLD = "on hold", "On Hold"