From 7ba86922ea2f0209df405e60eb71f30d7fd91a4a Mon Sep 17 00:00:00 2001 From: Alysia <109625347+allly-b@users.noreply.github.com> Date: Mon, 12 May 2025 11:52:17 -0700 Subject: [PATCH] Updated the cloudflare rotation instructions [no sandbox] (#3381) * updated the cloudflare rotation instructions * Delete unused comments --------- Co-authored-by: Alysia Broddrick <109625347+abroddrick@users.noreply.github.com> Co-authored-by: zandercymatics <141044360+zandercymatics@users.noreply.github.com> Co-authored-by: Erin <121973038+erinysong@users.noreply.github.com> --- docs/operations/runbooks/rotate_application_secrets.md | 6 +++--- src/registrar/views/portfolios.py | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/operations/runbooks/rotate_application_secrets.md b/docs/operations/runbooks/rotate_application_secrets.md index 1d36f6a74..bae9fe8d9 100644 --- a/docs/operations/runbooks/rotate_application_secrets.md +++ b/docs/operations/runbooks/rotate_application_secrets.md @@ -1,7 +1,7 @@ # HOWTO Rotate the Application's Secrets ======================== -Secrets are read from the running environment. +Below you will find sections for each of the application secrets which can & will be changed individually and expire at different times. Secrets are read from the running environment. Secrets are originally created with: @@ -114,9 +114,9 @@ need to be specified in the environment. ## REGISTRY_CL_ID and REGISTRY_PASSWORD -These are the login credentials for accessing the registry. +These are the login credentials for accessing the registry and they are set by Cloudflare. Cloudflare should notify us if and when registry credentials ever need to be changed. -## REGISTRY_CERT and REGISTRY_KEY and REGISTRY_KEY_PASSPHRASE +## Rotating REGISTRY_CERT, REGISTRY_KEY, and REGISTRY_KEY_PASSPHRASE for Cloudflare environments These are the client certificate and its private key used to identify the registrar to the registry during the establishment of a TCP connection. diff --git a/src/registrar/views/portfolios.py b/src/registrar/views/portfolios.py index 2a9b9684d..fe8095335 100644 --- a/src/registrar/views/portfolios.py +++ b/src/registrar/views/portfolios.py @@ -484,12 +484,10 @@ class PortfolioInvitedMemberView(DetailView, View): model = Portfolio context_object_name = "portfolio" template_name = "portfolio_member.html" - # form_class = PortfolioInvitedMemberForm pk_url_kwarg = "invitedmember_pk" def get(self, request, invitedmember_pk): portfolio_invitation = get_object_or_404(PortfolioInvitation, pk=invitedmember_pk) - # form = self.form_class(instance=portfolio_invitation) # We have to explicitely name these with member_ otherwise we'll have conflicts with context preprocessors member_has_view_all_requests_portfolio_permission = (