zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-26 04:28:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

Edge cases

Browse source
This commit is contained in:
zandercymatics 2024-07-03 12:54:10 -06:00
parent a9c91bc94a
commit 7a3f009713
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/assets/js/get-gov.js
View file

@ -1844,7 +1844,7 @@ document.addEventListener('DOMContentLoaded', function() {
} }
let inputFieldValue = inputField.value let inputFieldValue = inputField.value
if (readonlyField && inputFieldValue){ if (readonlyField && inputFieldValue || fieldName == "full_name"){
if (fieldName == "full_name"){ if (fieldName == "full_name"){
let firstName = document.querySelector(`#id_first_name`).value; let firstName = document.querySelector(`#id_first_name`).value;
let middleName = document.querySelector(`#id_middle_name`).value; let middleName = document.querySelector(`#id_middle_name`).value;
@ -1855,8 +1855,6 @@ document.addEventListener('DOMContentLoaded', function() {
}else { }else {
readonlyField.innerHTML = "Unknown"; readonlyField.innerHTML = "Unknown";
} }
}else {
readonlyField.innerHTML = inputValue;
} }
} }
} }

7
src/registrar/forms/user_profile.py
View file

@ -71,7 +71,7 @@ class UserProfileForm(forms.ModelForm):
class FinishSetupProfileForm(UserProfileForm): class FinishSetupProfileForm(UserProfileForm):
"""Form for updating user profile.""" """Form for updating user profile."""
full_name = forms.CharField(required=True, label="Full name") full_name = forms.CharField(required=False, label="Full name")
def clean(self): def clean(self):
cleaned_data = super().clean() cleaned_data = super().clean()
@ -93,7 +93,10 @@ class FinishSetupProfileForm(UserProfileForm):
self.fields["title"].label = "Title or role in your organization" self.fields["title"].label = "Title or role in your organization"
# Define the "full_name" value # Define the "full_name" value
full_name = None full_name = ""
if self.instance.first_name and self.instance.last_name: if self.instance.first_name and self.instance.last_name:
full_name = self.instance.get_formatted_name(return_unknown_when_none=False) full_name = self.instance.get_formatted_name(return_unknown_when_none=False)
self.fields["full_name"].initial = full_name self.fields["full_name"].initial = full_name
# Set full_name as required for styling purposes
self.fields["full_name"].widget.attrs['required'] = 'required'