zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-18 10:29:23 +02:00
Code Issues Projects Releases Packages Wiki Activity

solidify unit test

Browse source
This commit is contained in:
Rachid Mrad 2024-06-10 22:43:40 -04:00
parent 2586f10342
commit 7809ab5978
No known key found for this signature in database
2 changed files with 34 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

36
src/registrar/tests/test_views_request.py
View file

@ -109,21 +109,45 @@ class DomainRequestTests(TestWithUser, WebTest):
This tests that the domain requests get created only when they should. This tests that the domain requests get created only when they should.
""" """
# Get the intro page
intro_page = self.app.get(reverse("domain-request:")) intro_page = self.app.get(reverse("domain-request:"))
session_id = self.app.cookies[settings.SESSION_COOKIE_NAME] session_id = self.app.cookies[settings.SESSION_COOKIE_NAME]
# Select the form
intro_form = intro_page.forms[0] intro_form = intro_page.forms[0]
self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id)
intro_result = intro_form.submit()
# follow first redirect # Submit the form, this creates 1 Request
self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id) self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id)
intro_result.follow() response = intro_form.submit(name="submit_button", value="intro_acknowledge")
session_id = self.app.cookies[settings.SESSION_COOKIE_NAME]
# should see results in db # Landing on the next page used to create another 1 request
self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id)
response.follow()
# Check if a new DomainRequest object has been created
domain_request_count = DomainRequest.objects.count() domain_request_count = DomainRequest.objects.count()
self.assertEqual(domain_request_count, 1) self.assertEqual(domain_request_count, 1)
# AGAIN right away, this should NOT cause a new request to be created
# as a small threshold between 'Continue' submits indicate a use of the
# browser back button.
intro_form = intro_page.forms[0]
self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id)
response = intro_form.submit(name="submit_button", value="intro_acknowledge")
self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id)
response.follow()
domain_request_count = DomainRequest.objects.count()
self.assertEqual(domain_request_count, 1)
# One more time, dropping session which will set the last_submit_time to 0,
# therefore increasing the threshold and having us expect the creation of a new request
intro_form = intro_page.forms[0]
response = intro_form.submit(name="submit_button", value="intro_acknowledge")
response.follow()
domain_request_count = DomainRequest.objects.count()
self.assertEqual(domain_request_count, 2)
@boto3_mocking.patching @boto3_mocking.patching
def test_domain_request_form_submission(self): def test_domain_request_form_submission(self):
""" """

10
src/registrar/views/domain_request.py
View file

@ -220,7 +220,7 @@ class DomainRequestWizard(DomainRequestWizardPermissionView, TemplateView):
self.storage["domain_request_id"] = kwargs["id"] self.storage["domain_request_id"] = kwargs["id"]
self.storage["step_history"] = self.db_check_for_unlocking_steps() self.storage["step_history"] = self.db_check_for_unlocking_steps()
# if accessing this class directly, redirect to either to an acknowledgement # if accessing this class directly, redirect to either to an acknowledgement
# page or to the first step in the processes (if an edit rather than a new request); # page or to the first step in the processes (if an edit rather than a new request);
# subclasseswill NOT be redirected. The purpose of this is to allow code to # subclasseswill NOT be redirected. The purpose of this is to allow code to
# send users "to the domain request wizard" without needing to know which view # send users "to the domain request wizard" without needing to know which view
@ -234,7 +234,7 @@ class DomainRequestWizard(DomainRequestWizardPermissionView, TemplateView):
return render(request, "domain_request_intro.html", context={}) return render(request, "domain_request_intro.html", context={})
else: else:
return self.goto(self.steps.first) return self.goto(self.steps.first)
context = self.get_context_data() context = self.get_context_data()
self.steps.current = current_url self.steps.current = current_url
context["forms"] = self.get_forms() context["forms"] = self.get_forms()
@ -462,10 +462,8 @@ class DomainRequestWizard(DomainRequestWizardPermissionView, TemplateView):
# if user has acknowledged the intro message # if user has acknowledged the intro message
if button == "intro_acknowledge": if button == "intro_acknowledge":
print("intro_acknowledge")
if request.path_info == self.NEW_URL_NAME: if request.path_info == self.NEW_URL_NAME:
print("Creating DomainRequest...") last_submit_time = request.session.get("last_submit_time", 0)
last_submit_time = request.session.get('last_submit_time', 0)
# Check if the last submit was very recent, indicating a back button -> submit sequence # Check if the last submit was very recent, indicating a back button -> submit sequence
if current_time - last_submit_time > 5: # 5 seconds threshold if current_time - last_submit_time > 5: # 5 seconds threshold
@ -474,7 +472,7 @@ class DomainRequestWizard(DomainRequestWizardPermissionView, TemplateView):
del self.storage del self.storage
# Update the last submit time # Update the last submit time
request.session['last_submit_time'] = current_time request.session["last_submit_time"] = current_time
return self.goto(self.steps.first) return self.goto(self.steps.first)