From 71b8bf38a18684f61a283a9542028bdf0147f7de Mon Sep 17 00:00:00 2001 From: David Kennedy Date: Sat, 12 Oct 2024 10:40:44 -0400 Subject: [PATCH] properly handle None condition for roles --- src/registrar/views/portfolio_members_json.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/registrar/views/portfolio_members_json.py b/src/registrar/views/portfolio_members_json.py index 374982795..2f43a26ee 100644 --- a/src/registrar/views/portfolio_members_json.py +++ b/src/registrar/views/portfolio_members_json.py @@ -155,7 +155,7 @@ def serialize_members(request, portfolio, item, user): view_only = not user.has_edit_members_portfolio_permission(portfolio) or not user_can_edit_other_users - is_admin = UserPortfolioRoleChoices.ORGANIZATION_ADMIN in item.get("roles_display", []) + is_admin = UserPortfolioRoleChoices.ORGANIZATION_ADMIN in (item.get("roles_display", [])) action_url = reverse("member" if item["source"] == "permission" else "invitedmember", kwargs={"pk": item["id"]}) # Serialize member data