diff --git a/src/registrar/views/domain.py b/src/registrar/views/domain.py index 29d06da39..f945bc443 100644 --- a/src/registrar/views/domain.py +++ b/src/registrar/views/domain.py @@ -123,8 +123,6 @@ class DomainAuthorizingOfficialView(DomainPermissionView, FormMixin): self.request, "The authorizing official for this domain has been updated." ) - - # superclass has the redirect return super().form_valid(form) @@ -377,7 +375,6 @@ class DomainAddUserView(DomainPermissionView, FormMixin): messages.success(self.request, f"Added user {requested_email}.") - return redirect(self.get_success_url()) diff --git a/src/registrar/views/utility/mixins.py b/src/registrar/views/utility/mixins.py index 57bb97be6..fd58b3475 100644 --- a/src/registrar/views/utility/mixins.py +++ b/src/registrar/views/utility/mixins.py @@ -100,7 +100,7 @@ class DomainPermission(PermissionsLoginMixin): if DomainInformation.objects.filter(id=pk).exists(): requested_domain = DomainInformation.objects.get(id=pk) - if not requested_domain.domain_application.status in valid_domain_statuses: + if requested_domain.domain_application.status not in valid_domain_statuses: return False # Valid session keys exist, diff --git a/src/registrar/views/utility/permission_views.py b/src/registrar/views/utility/permission_views.py index aa4c79690..417ee8417 100644 --- a/src/registrar/views/utility/permission_views.py +++ b/src/registrar/views/utility/permission_views.py @@ -3,9 +3,7 @@ import abc # abstract base class from django.views.generic import DetailView, DeleteView, TemplateView -from django.contrib.contenttypes.models import ContentType from registrar.models import Domain, DomainApplication, DomainInvitation -from django.contrib.admin.models import LogEntry, CHANGE from .mixins import ( DomainPermission,