zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-12 20:49:41 +02:00
Code Issues Projects Releases Packages Wiki Activity

Linter fixes

Browse source
This commit is contained in:
matthewswspence 2024-08-28 09:31:01 -05:00
parent febd9566ce
commit 6aa5986441
No known key found for this signature in database
GPG key ID: FB458202A7852BA4
2 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/registrar/management/commands/update_first_ready.py
View file

@ -30,7 +30,10 @@ class Command(BaseCommand, PopulateScriptTemplate):
def custom_filter(self, records: BaseManager[Domain]) -> BaseManager[Domain]: def custom_filter(self, records: BaseManager[Domain]) -> BaseManager[Domain]:
to_include_pks = [] to_include_pks = []
for record in records: for record in records:
if TransitionDomain.objects.filter(domain_name=record.name).exists() and record.first_ready != record.created_at.date(): #noqa if (
TransitionDomain.objects.filter(domain_name=record.name).exists()
and record.first_ready != record.created_at.date()
): # noqa
to_include_pks.append(record.pk) to_include_pks.append(record.pk)
return records.filter(pk__in=to_include_pks) return records.filter(pk__in=to_include_pks)

9
src/registrar/management/commands/utility/terminal_helper.py
View file

@ -93,7 +93,7 @@ class PopulateScriptTemplate(ABC):
object_class: The Django model class that you want to perform the bulk update on. object_class: The Django model class that you want to perform the bulk update on.
This should be the actual class, not a string of the class name. This should be the actual class, not a string of the class name.
filter_conditions: dictionary of valid Django Queryset filter conditions filter_conditions: dictionary of valid Django Queryset filter conditions
(e.g. {'verification_type__isnull'=True}). (e.g. {'verification_type__isnull'=True}).
fields_to_update: List of strings specifying which fields to update. fields_to_update: List of strings specifying which fields to update.
@ -102,7 +102,7 @@ class PopulateScriptTemplate(ABC):
debug: Whether to log script run summary in debug mode. debug: Whether to log script run summary in debug mode.
Default: True. Default: True.
verbose: Whether to print a detailed run summary *before* run confirmation. verbose: Whether to print a detailed run summary *before* run confirmation.
Default: False. Default: False.
Raises: Raises:
@ -113,7 +113,7 @@ class PopulateScriptTemplate(ABC):
records = object_class.objects.filter(**filter_conditions) records = object_class.objects.filter(**filter_conditions)
# apply custom filter # apply custom filter
records=self.custom_filter(records) records = self.custom_filter(records)
readable_class_name = self.get_class_name(object_class) readable_class_name = self.get_class_name(object_class)
@ -184,9 +184,10 @@ class PopulateScriptTemplate(ABC):
def custom_filter(self, records: BaseManager[Model]) -> BaseManager[Model]: def custom_filter(self, records: BaseManager[Model]) -> BaseManager[Model]:
"""Override to define filters that can't be represented by django queryset field lookups. """Override to define filters that can't be represented by django queryset field lookups.
Applied to individual records *after* filter_conditions. True means """ Applied to individual records *after* filter_conditions. True means"""
return records return records
class TerminalHelper: class TerminalHelper:
@staticmethod @staticmethod
def log_script_run_summary( def log_script_run_summary(