From 68ea6db752016919bf79e995e327bcc77c043e76 Mon Sep 17 00:00:00 2001 From: Rachid Mrad Date: Thu, 17 Oct 2024 13:37:48 -0400 Subject: [PATCH] Fix last active JS bug --- src/registrar/assets/js/get-gov.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/registrar/assets/js/get-gov.js b/src/registrar/assets/js/get-gov.js index cd2e251ab..ab94bec7a 100644 --- a/src/registrar/assets/js/get-gov.js +++ b/src/registrar/assets/js/get-gov.js @@ -1975,20 +1975,23 @@ class MembersTable extends LoadTableBase { const options = { year: 'numeric', month: 'short', day: 'numeric' }; // Handle last_active values - let last_active = member.last_active; + let last_active = NaN + last_active = member.last_active; let last_active_formatted = ''; let last_active_sort_value = ''; // Handle 'Invited' or null/empty values differently from valid dates - if (last_active && last_active !== invited) { + if (last_active !== invited) { try { // Try to parse the last_active as a valid date - last_active = new Date(last_active); + // Try to parse the last_active as a valid date + const parsedDate = new Date(last_active); if (!isNaN(last_active)) { - last_active_formatted = last_active.toLocaleDateString('en-US', options); - last_active_sort_value = last_active.getTime(); // For sorting purposes + last_active_formatted = parsedDate.toLocaleDateString('en-US', options); + last_active_sort_value = parsedDate.getTime(); // For sorting purposes } else { - last_active_formatted='Invalid date' + last_active_formatted='Invalid date'; + last_active_sort_value = 'Invalid date'; } } catch (e) { console.error(`Error parsing date: ${last_active}. Error: ${e}`);