zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-22 02:36:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

handling of OBJECT_EXISTS in nameserver create_host and update_host methods

Browse source
This commit is contained in:
David Kennedy 2023-10-31 10:42:42 -04:00
parent 918c5ef0b2
commit 662bb1a1ef
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/registrar/models/domain.py
View file

@ -277,7 +277,12 @@ class Domain(TimeStampedModel, DomainHelper):
return response.code return response.code
except RegistryError as e: except RegistryError as e:
logger.error("Error _create_host, code was %s error was %s" % (e.code, e)) logger.error("Error _create_host, code was %s error was %s" % (e.code, e))
raise e # OBJECT_EXISTS is an expected error code that should not raise
# an exception, rather return the code to be handled separately
if response and response.code == ErrorCode.OBJECT_EXISTS:
return response.code
else:
raise e
def _convert_list_to_dict(self, listToConvert: list[tuple[str, list]]): def _convert_list_to_dict(self, listToConvert: list[tuple[str, list]]):
"""converts a list of hosts into a dictionary """converts a list of hosts into a dictionary
@ -1625,7 +1630,12 @@ class Domain(TimeStampedModel, DomainHelper):
return response.code return response.code
except RegistryError as e: except RegistryError as e:
logger.error("Error _update_host, code was %s error was %s" % (e.code, e)) logger.error("Error _update_host, code was %s error was %s" % (e.code, e))
raise e # OBJECT_EXISTS is an expected error code that should not raise
# an exception, rather return the code to be handled separately
if response and response.code == ErrorCode.OBJECT_EXISTS:
return response.code
else:
raise e
def addAndRemoveHostsFromDomain( def addAndRemoveHostsFromDomain(
self, hostsToAdd: list[str], hostsToDelete: list[str] self, hostsToAdd: list[str], hostsToDelete: list[str]