zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-11 20:19:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

revise IDs in contact_detail_list to classes

Browse source
This commit is contained in:
Rachid Mrad 2024-11-06 12:25:49 -05:00
parent e948dc4311
commit 661f9ff254
No known key found for this signature in database
2 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/registrar/assets/js/get-gov-admin.js
View file

@ -334,9 +334,9 @@ function handlePortfolioSelection() {
function updateContactInfo(data) { function updateContactInfo(data) {
if (!contactList) return; if (!contactList) return;
const titleSpan = contactList.querySelector("#contact_info_title"); const titleSpan = contactList.querySelector(".contact_info_title");
const emailSpan = contactList.querySelector("#contact_info_email"); const emailSpan = contactList.querySelector(".contact_info_email");
const phoneSpan = contactList.querySelector("#contact_info_phone"); const phoneSpan = contactList.querySelector(".contact_info_phone");
if (titleSpan) { if (titleSpan) {
titleSpan.textContent = data.title || "None"; titleSpan.textContent = data.title || "None";
@ -1277,10 +1277,10 @@ document.addEventListener('DOMContentLoaded', function() {
if (contacts) { if (contacts) {
contacts.forEach(contact => { contacts.forEach(contact => {
// Check if the <dl> element is not empty // Check if the <dl> element is not empty
const name = contact.querySelector('a#contact_info_name')?.innerText; const name = contact.querySelector('a.contact_info_name')?.innerText;
const title = contact.querySelector('span#contact_info_title')?.innerText; const title = contact.querySelector('span.contact_info_title')?.innerText;
const email = contact.querySelector('span#contact_info_email')?.innerText; const email = contact.querySelector('span.contact_info_email')?.innerText;
const phone = contact.querySelector('span#contact_info_phone')?.innerText; const phone = contact.querySelector('span.contact_info_phone')?.innerText;
const url = nameToUrlMap[name] || '#'; const url = nameToUrlMap[name] || '#';
// Format the contact information // Format the contact information
const listItem = document.createElement('li'); const listItem = document.createElement('li');
@ -1331,9 +1331,9 @@ document.addEventListener('DOMContentLoaded', function() {
const seniorOfficialDiv = document.querySelector('.form-row.field-senior_official'); const seniorOfficialDiv = document.querySelector('.form-row.field-senior_official');
const seniorOfficialElement = document.getElementById('id_senior_official'); const seniorOfficialElement = document.getElementById('id_senior_official');
const seniorOfficialName = seniorOfficialElement.options[seniorOfficialElement.selectedIndex].text; const seniorOfficialName = seniorOfficialElement.options[seniorOfficialElement.selectedIndex].text;
const seniorOfficialTitle = extractTextById('contact_info_title', seniorOfficialDiv); const seniorOfficialTitle = seniorOfficialDiv.querySelector('.contact_info_title');
const seniorOfficialEmail = extractTextById('contact_info_email', seniorOfficialDiv); const seniorOfficialEmail = seniorOfficialDiv.querySelector('.contact_info_email');
const seniorOfficialPhone = extractTextById('contact_info_phone', seniorOfficialDiv); const seniorOfficialPhone = seniorOfficialDiv.querySelector('.contact_info_phone');
let seniorOfficialInfo = `${seniorOfficialName}${seniorOfficialTitle}${seniorOfficialEmail}${seniorOfficialPhone}`; let seniorOfficialInfo = `${seniorOfficialName}${seniorOfficialTitle}${seniorOfficialEmail}${seniorOfficialPhone}`;
const html_summary = `<strong>Recommendation:</strong></br>` + const html_summary = `<strong>Recommendation:</strong></br>` +
@ -1617,9 +1617,9 @@ document.addEventListener('DOMContentLoaded', function() {
function updateContactInfo(data) { function updateContactInfo(data) {
if (!contactList) return; if (!contactList) return;
const titleSpan = contactList.querySelector("#contact_info_title"); const titleSpan = contactList.querySelector(".contact_info_title");
const emailSpan = contactList.querySelector("#contact_info_email"); const emailSpan = contactList.querySelector(".contact_info_email");
const phoneSpan = contactList.querySelector("#contact_info_phone"); const phoneSpan = contactList.querySelector(".contact_info_phone");
if (titleSpan) { if (titleSpan) {
titleSpan.textContent = data.title || "None"; titleSpan.textContent = data.title || "None";

10
src/registrar/templates/django/admin/includes/contact_detail_list.html
View file

@ -6,7 +6,7 @@
{% if show_formatted_name %} {% if show_formatted_name %}
{% if user.get_formatted_name %} {% if user.get_formatted_name %}
<a id="contact_info_name" href="{% url 'admin:registrar_contact_change' user.id %}">{{ user.get_formatted_name }}</a> <a class="contact_info_name" href="{% url 'admin:registrar_contact_change' user.id %}">{{ user.get_formatted_name }}</a>
{% else %} {% else %}
None None
{% endif %} {% endif %}
@ -16,7 +16,7 @@
{% if user|has_contact_info %} {% if user|has_contact_info %}
{# Title #} {# Title #}
{% if user.title %} {% if user.title %}
<span id="contact_info_title">{{ user.title }}</span> <span class="contact_info_title">{{ user.title }}</span>
{% else %} {% else %}
None None
{% endif %} {% endif %}
@ -24,7 +24,7 @@
{# Email #} {# Email #}
{% if user.email %} {% if user.email %}
<span id="contact_info_email">{{ user.email }}</span> <span class="contact_info_email">{{ user.email }}</span>
{% include "admin/input_with_clipboard.html" with field=user invisible_input_field=True %} {% include "admin/input_with_clipboard.html" with field=user invisible_input_field=True %}
<br> <br>
{% else %} {% else %}
@ -33,7 +33,7 @@
{# Phone #} {# Phone #}
{% if user.phone %} {% if user.phone %}
<span id="contact_info_phone">{{ user.phone }}</span> <span class="contact_info_phone">{{ user.phone }}</span>
<br> <br>
{% else %} {% else %}
None<br> None<br>
@ -44,6 +44,6 @@
{% endif %} {% endif %}
{% if user_verification_type and not skip_additional_contact_info %} {% if user_verification_type and not skip_additional_contact_info %}
<span id="contact_info_phone">{{ user_verification_type }}</span> <span class="contact_info_phone">{{ user_verification_type }}</span>
{% endif %} {% endif %}
</address> </address>