zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-26 20:48:40 +02:00
Code Issues Projects Releases Packages Wiki Activity

Implemented feedback (plus fixed bug where cancel button validates form)

Browse source
This commit is contained in:
CocoByte 2024-10-31 13:31:13 -06:00
parent 0153627a9e
commit 612b7b68be
No known key found for this signature in database
GPG key ID: BBFAA2526384C97F
4 changed files with 19 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/.pa11yci
View file

@ -20,6 +20,8 @@
"http://localhost:8080/request/anything_else/", "http://localhost:8080/request/anything_else/",
"http://localhost:8080/request/requirements/", "http://localhost:8080/request/requirements/",
"http://localhost:8080/request/finished/", "http://localhost:8080/request/finished/",
"http://localhost:8080/user-profile/" "http://localhost:8080/user-profile/",
"http://localhost:8080/members/",
"http://localhost:8080/members/new-member"
] ]
} }

2
src/registrar/templates/includes/header_extended.html
View file

@ -95,7 +95,7 @@
{% if has_organization_members_flag %} {% if has_organization_members_flag %}
<li class="usa-nav__primary-item"> <li class="usa-nav__primary-item">
<a href="/members/" class="usa-nav-link {% if path|is_members_subpage %} usa-current{% endif %}"> <a href="{% url 'members' %}" class="usa-nav-link {% if path|is_members_subpage %} usa-current{% endif %}">
Members Members
</a> </a>
</li> </li>

2
src/registrar/templates/portfolio_members.html
View file

@ -21,7 +21,7 @@
{% if has_edit_members_portfolio_permission %} {% if has_edit_members_portfolio_permission %}
<div class="mobile:grid-col-12 tablet:grid-col-6"> <div class="mobile:grid-col-12 tablet:grid-col-6">
<p class="float-right-tablet tablet:margin-y-0"> <p class="float-right-tablet tablet:margin-y-0">
<a href="new-member" class="usa-button" <a href="{% url 'new-member' %}" class="usa-button"
> >
Add a new member Add a new member
</a> </a>

12
src/registrar/templates/portfolio_members_add_new.html
View file

@ -79,10 +79,8 @@
<!-- Admin access form --> <!-- Admin access form -->
<div id="new-member-admin-permissions" class="margin-top-2"> <div id="new-member-admin-permissions" class="margin-top-2">
<legend>
<h2>Admin access permissions</h2> <h2>Admin access permissions</h2>
<p>Member permissions available for admin-level acccess.</p> <p>Member permissions available for admin-level acccess.</p>
</legend>
<h3 class="margin-bottom-0">Organization domain requests</h3> <h3 class="margin-bottom-0">Organization domain requests</h3>
{% with group_classes="usa-form-editable usa-form-editable--no-border padding-top-0" %} {% with group_classes="usa-form-editable usa-form-editable--no-border padding-top-0" %}
@ -97,23 +95,21 @@
<!-- Basic access form --> <!-- Basic access form -->
<div id="new-member-basic-permissions" class="margin-top-2"> <div id="new-member-basic-permissions" class="margin-top-2">
<legend>
<h2>Basic member permissions</h2> <h2>Basic member permissions</h2>
<p>Member permissions available for basic-level access</p> <p>Member permissions available for basic-level access</p>
{% input_with_errors form.basic_org_domain_request_permissions %} {% input_with_errors form.basic_org_domain_request_permissions %}
</legend>
</div> </div>
<!-- Submit/cancel buttons --> <!-- Submit/cancel buttons -->
<div class="margin-top-3"> <div class="margin-top-3">
<button <a
href="/members/" type="button"
href="{% url 'members' %}"
class="usa-button usa-button--outline" class="usa-button usa-button--outline"
name="btn-cancel-click" name="btn-cancel-click"
aria-label="Cancel adding new member" aria-label="Cancel adding new member"
>Cancel >Cancel
</button> </a>
<button type="submit" class="usa-button">Invite Member</button> <button type="submit" class="usa-button">Invite Member</button>
</div> </div>
</form> </form>