Implemented feedback (plus fixed bug where cancel button validates form)

src/.pa11yci

@@ -20,6 +20,8 @@
         "http://localhost:8080/request/anything_else/",
         "http://localhost:8080/request/requirements/",
         "http://localhost:8080/request/finished/",
-        "http://localhost:8080/user-profile/"
+        "http://localhost:8080/user-profile/",
+        "http://localhost:8080/members/",
+        "http://localhost:8080/members/new-member"
     ]
 }

src/registrar/templates/includes/header_extended.html

@@ -95,7 +95,7 @@
 
             {% if has_organization_members_flag %}
                 <li class="usa-nav__primary-item">
-                    <a href="/members/" class="usa-nav-link {% if path|is_members_subpage %} usa-current{% endif %}">
+                    <a href="{% url 'members' %}" class="usa-nav-link {% if path|is_members_subpage %} usa-current{% endif %}">
                         Members
                     </a>
                 </li>

src/registrar/templates/portfolio_members.html

@@ -21,7 +21,7 @@
           {% if has_edit_members_portfolio_permission %}
           <div class="mobile:grid-col-12 tablet:grid-col-6">
               <p class="float-right-tablet tablet:margin-y-0">
-                  <a href="new-member" class="usa-button"
+                  <a href="{% url 'new-member' %}" class="usa-button"
                   >
                       Add a new member
                   </a>

src/registrar/templates/portfolio_members_add_new.html

@@ -79,41 +79,37 @@
 
 <!-- Admin access form -->
 <div id="new-member-admin-permissions" class="margin-top-2">
-  <legend>
     <h2>Admin access permissions</h2>
     <p>Member permissions available for admin-level acccess.</p>
-  </legend>
-  
-  <h3 class="margin-bottom-0">Organization domain requests</h3>
-  {% with group_classes="usa-form-editable usa-form-editable--no-border padding-top-0" %}
-    {% input_with_errors form.admin_org_domain_request_permissions %}
-  {% endwith %}
 
-  <h3 class="margin-bottom-0 margin-top-3">Organization members</h3>
-  {% with group_classes="usa-form-editable usa-form-editable--no-border padding-top-0" %}
-    {% input_with_errors form.admin_org_members_permissions %}
-  {% endwith %}
-</div>
+    <h3 class="margin-bottom-0">Organization domain requests</h3>
+    {% with group_classes="usa-form-editable usa-form-editable--no-border padding-top-0" %}
+      {% input_with_errors form.admin_org_domain_request_permissions %}
+    {% endwith %}
+
+    <h3 class="margin-bottom-0 margin-top-3">Organization members</h3>
+    {% with group_classes="usa-form-editable usa-form-editable--no-border padding-top-0" %}
+      {% input_with_errors form.admin_org_members_permissions %}
+    {% endwith %}
+  </div>
 
 <!-- Basic access form -->
 <div id="new-member-basic-permissions" class="margin-top-2">
-  <legend>
     <h2>Basic member permissions</h2>
     <p>Member permissions available for basic-level access</p>
     {% input_with_errors form.basic_org_domain_request_permissions %}
-  </legend>
-  
 </div>
 
 <!-- Submit/cancel buttons -->
 <div class="margin-top-3">
-  <button
-  href="/members/"
+  <a
+    type="button"
+    href="{% url 'members' %}"
     class="usa-button usa-button--outline"
     name="btn-cancel-click"
     aria-label="Cancel adding new member"
   >Cancel
-</button>
+</a>
   <button type="submit" class="usa-button">Invite Member</button>
 </div>
 </form>