zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-06-09 22:14:43 +02:00
Code Issues Projects Releases Packages Wiki Activity

Respond to PR feedback

Browse source
This commit is contained in:
Seamus Johnston 2023-01-06 11:45:29 -06:00
parent 1c45ac55b3
commit 607f181819
No known key found for this signature in database
GPG key ID: 2F21225985069105
4 changed files with 103 additions and 105 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/registrar/forms/application_wizard.py
View file

@ -36,7 +36,7 @@ class RegistrarForm(forms.Form):
@classmethod
def from_database(cls, obj: DomainApplication | Contact | None):
"""Initializes this form's fields with values gotten from `obj`."""
"""Returns a dict of form field values gotten from `obj`."""
if obj is None:
return {}
return {
@ -99,7 +99,6 @@ class OrganizationContactForm(RegistrarForm):
class AuthorizingOfficialForm(RegistrarForm):
def to_database(self, obj):
"""Adds this form's cleaned data to `obj` and saves `obj`."""
if not self.is_valid():
return
contact = getattr(obj, "authorizing_official", None)
@ -113,7 +112,6 @@ class AuthorizingOfficialForm(RegistrarForm):
@classmethod
def from_database(cls, obj):
"""Initializes this form's fields with values gotten from `obj`."""
contact = getattr(obj, "authorizing_official", None)
return super().from_database(contact)
@ -130,7 +128,6 @@ class AuthorizingOfficialForm(RegistrarForm):
class CurrentSitesForm(RegistrarForm):
def to_database(self, obj):
"""Adds this form's cleaned data to `obj` and saves `obj`."""
if not self.is_valid():
return
obj.save()
@ -141,7 +138,6 @@ class CurrentSitesForm(RegistrarForm):
@classmethod
def from_database(cls, obj):
"""Initializes this form's fields with values gotten from `obj`."""
current_website = obj.current_websites.first()
if current_website is not None:
return {"current_site": current_website.website}
@ -157,7 +153,6 @@ class CurrentSitesForm(RegistrarForm):
class DotGovDomainForm(RegistrarForm):
def to_database(self, obj):
"""Adds this form's cleaned data to `obj` and saves `obj`."""
if not self.is_valid():
return
normalized = Domain.normalize(
@ -183,7 +178,6 @@ class DotGovDomainForm(RegistrarForm):
@classmethod
def from_database(cls, obj):
"""Initializes this form's fields with values gotten from `obj`."""
values = {}
requested_domain = getattr(obj, "requested_domain", None)
if requested_domain is not None:
@ -209,7 +203,6 @@ class PurposeForm(RegistrarForm):
class YourContactForm(RegistrarForm):
def to_database(self, obj):
"""Adds this form's cleaned data to `obj` and saves `obj`."""
if not self.is_valid():
return
contact = getattr(obj, "submitter", None)
@ -223,7 +216,6 @@ class YourContactForm(RegistrarForm):
@classmethod
def from_database(cls, obj):
"""Initializes this form's fields with values gotten from `obj`."""
contact = getattr(obj, "submitter", None)
return super().from_database(contact)
@ -240,7 +232,6 @@ class YourContactForm(RegistrarForm):
class OtherContactsForm(RegistrarForm):
def to_database(self, obj):
"""Adds this form's cleaned data to `obj` and saves `obj`."""
if not self.is_valid():
return
obj.save()
@ -256,7 +247,6 @@ class OtherContactsForm(RegistrarForm):
@classmethod
def from_database(cls, obj):
"""Initializes this form's fields with values gotten from `obj`."""
other_contacts = obj.other_contacts.first()
return super().from_database(other_contacts)