zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-15 17:17:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactored DomainAdmin response_change into multiple methods; updated create_user in common.py for properly setting is_staff for test users; added tearDown for TestDomainAdmin

Browse source
This commit is contained in:
David Kennedy 2023-09-07 07:18:38 -04:00
parent 744c6fa48a
commit 5c41e4a28f
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
3 changed files with 42 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

66
src/registrar/admin.py
View file

@ -178,39 +178,45 @@ class DomainAdmin(ListHeaderAdmin):
PLACE_HOLD = "_place_client_hold"
REMOVE_HOLD = "_remove_client_hold"
if PLACE_HOLD in request.POST:
try:
obj.place_client_hold()
obj.save()
except Exception as err:
self.message_user(request, err, messages.ERROR)
else:
self.message_user(
request,
(
"%s is in client hold. This domain is no longer accessible on"
" the public internet."
)
% obj.name,
)
return HttpResponseRedirect(".")
return self.do_place_client_hold(request, obj)
elif REMOVE_HOLD in request.POST:
try:
obj.remove_client_hold()
obj.save()
except Exception as err:
self.message_user(request, err, messages.ERROR)
else:
self.message_user(
request,
(
"%s is ready. This domain is accessible on the public "
"internet."
)
% obj.name,
)
return HttpResponseRedirect(".")
return self.do_remove_client_hold(request, obj)
return super().response_change(request, obj)
def do_place_client_hold(self, request, obj):
try:
obj.place_client_hold()
obj.save()
except Exception as err:
self.message_user(request, err, messages.ERROR)
else:
self.message_user(
request,
(
"%s is in client hold. This domain is no longer accessible on"
" the public internet."
)
% obj.name,
)
return HttpResponseRedirect(".")
def do_remove_client_hold(self, request, obj):
try:
obj.remove_client_hold()
obj.save()
except Exception as err:
self.message_user(request, err, messages.ERROR)
else:
self.message_user(
request,
(
"%s is ready. This domain is accessible on the public "
"internet."
)
% obj.name,
)
return HttpResponseRedirect(".")
def has_change_permission(self, request, obj=None):
# Fixes a bug wherein users which are only is_staff
# can access 'change' when GET,