zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-28 16:29:54 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix unit test, linting, cleanup

Browse source
This commit is contained in:
zandercymatics 2024-05-21 15:51:42 -06:00
parent 9c230fcfa7
commit 5a05512944
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
14 changed files with 71 additions and 78 deletions
Download patch file Download diff file Expand all files Collapse all files

35
src/djangooidc/views.py
View file

@ -99,9 +99,18 @@ def login_callback(request):
return CLIENT.create_authn_request(request.session)
user = authenticate(request=request, **userinfo)
if user:
# Set login metadata about this user
# (verification_type for instance)
_set_authenticated_user_metadata(user)
# Fixture users kind of exist in a superposition of verification types,
# because while the system "verified" them, if they login,
# we don't know how the user themselves was verified through login.gov until
# they actually try logging in. This edge-case only matters in non-production environments.
fixture_user = User.VerificationTypeChoices.FIXTURE_USER
is_fixture_user = user.verification_type and user.verification_type == fixture_user
# Set the verification type if it doesn't already exist or if its a fixture user
if not user.verification_type or is_fixture_user:
user.set_user_verification_type()
user.save()
login(request, user)
@ -131,26 +140,6 @@ def login_callback(request):
return error_page(request, err)
def _set_authenticated_user_metadata(user):
"""Does checks on the recieved authenticated user from login_callback,
and updates fields accordingly."""
should_update_user = False
# Fixture users kind of exist in a superposition of verification types,
# because while the system "verified" them, if they login,
# we don't know how the user themselves was verified through login.gov until
# they actually try logging in. This edge-case only matters in non-production environments.
fixture_user = User.VerificationTypeChoices.FIXTURE_USER
is_fixture_user = user.verification_type and user.verification_type == fixture_user
# Set the verification type if it doesn't already exist or if its a fixture user
if not user.verification_type or is_fixture_user:
user.set_user_verification_type()
should_update_user = True
if should_update_user:
user.save()
def _requires_step_up_auth(userinfo):
"""if User.needs_identity_verification and step_up_acr_value not in
ial returned from callback, return True"""