From 57f34280255b84b0dad2b3971b6d6c98a722e04e Mon Sep 17 00:00:00 2001 From: Neil Martinsen-Burrell Date: Tue, 4 Apr 2023 15:34:51 -0500 Subject: [PATCH] Go back to using get_or_create --- src/registrar/models/domain_invitation.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/registrar/models/domain_invitation.py b/src/registrar/models/domain_invitation.py index 55822c53a..7cc2a5432 100644 --- a/src/registrar/models/domain_invitation.py +++ b/src/registrar/models/domain_invitation.py @@ -62,15 +62,10 @@ class DomainInvitation(TimeStampedModel): ) # and create a role for that user on this domain - try: - UserDomainRole.objects.get( - user=user, domain=self.domain, role=UserDomainRole.Roles.ADMIN - ) - except UserDomainRole.DoesNotExist: - UserDomainRole.objects.create( - user=user, domain=self.domain, role=UserDomainRole.Roles.ADMIN - ) - else: + _, created = UserDomainRole.objects.get_or_create( + user=user, domain=self.domain, role=UserDomainRole.Roles.ADMIN + ) + if not created: # something strange happened and this role already existed when # the invitation was retrieved. Log that this occurred. logger.warn(