zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-16 06:24:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix from asserttrue to assertequal and update 1 test case

Browse source
This commit is contained in:
Rebecca Hsieh 2023-09-26 13:45:02 -07:00
parent 07aa476b6a
commit 5523d06e59
No known key found for this signature in database
GPG key ID: 644527A2F375A379
1 changed files with 5 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/registrar/tests/test_models_domain.py
View file

@ -534,6 +534,7 @@ class TestRegistrantNameservers(MockEppLib):
""" """
super().setUp() super().setUp()
self.domain, _ = Domain.objects.get_or_create(name="my-nameserver.gov", state=Domain.State.DNS_NEEDED) self.domain, _ = Domain.objects.get_or_create(name="my-nameserver.gov", state=Domain.State.DNS_NEEDED)
def test_get_nameserver_changes(self): def test_get_nameserver_changes(self):
self.domain._cache["hosts"]=[{ self.domain._cache["hosts"]=[{
"name": "ns1.example.com", "name": "ns1.example.com",
@ -543,27 +544,16 @@ class TestRegistrantNameservers(MockEppLib):
"addrs": ["1.2.3"] "addrs": ["1.2.3"]
}, },
{"name": "ns3.example.com", {"name": "ns3.example.com",
"addrs": None "addrs": ["1.2.3"]
} }
] ]
newChanges=[("ns1.example.com",),("ns3.example.com",["1.2.4"]),("ns4.example.com",)] newChanges=[("ns1.example.com",),("ns3.example.com",["1.2.4"]),("ns4.example.com",)]
deleted_values,updated_values,new_values, oldNameservers=self.domain.getNameserverChanges(newChanges) deleted_values,updated_values,new_values, oldNameservers=self.domain.getNameserverChanges(newChanges)
# print(f"deleted: {deleted_values}\n")
# print(f"updated_values: {updated_values}\n")
# print(f"new_values: {new_values}\n")
# print(f"oldNameservers: {oldNameservers}\n")
# print("CHANGE")
# print(self.domain._convert_list_to_dict(newChanges))
# Q: This is asserting that 1.2.3 was deleted vs updated -- is this ok or a bug
self.assertEqual(deleted_values, [('ns2.example.com', ['1.2.3'])]) self.assertEqual(deleted_values, [('ns2.example.com', ['1.2.3'])])
self.assertTrue(updated_values, [('ns3.example.com', ['1.2.4'])]) self.assertEqual(updated_values, [('ns3.example.com', ['1.2.4'])])
self.assertTrue(new_values, {'ns4.example.com'}) self.assertEqual(new_values, {'ns4.example.com'})
self.assertTrue(oldNameservers, [('ns1.example.com', None), ('ns2.example.com', ['1.2.3']), ('ns3.example.com', None)]) self.assertEqual(oldNameservers, [('ns1.example.com', None), ('ns2.example.com', ['1.2.3']), ('ns3.example.com', ['1.2.3'])])
#expecting:
# updated_values==1 -- which is "ns3.example.com"
# newvalues==1 -- which is "ns4.example.com"
# deleted==1 --which is "ns2.example.com"
def test_user_adds_one_nameserver(self): def test_user_adds_one_nameserver(self):