zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-31 23:16:36 +02:00
Code Issues Projects Releases Packages Wiki Activity

removed unnecessary permission

Browse source
This commit is contained in:
David Kennedy 2025-03-18 09:02:14 -04:00
parent 5528390ee9
commit 531d8c7e94
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
6 changed files with 8 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/registrar/admin.py
View file

@ -4361,7 +4361,7 @@ class DomainAdmin(ListHeaderAdmin, ImportExportRegistrarModelAdmin):
if (
request.user.has_perm("registrar.full_access_permission")
or request.user.has_perm("registrar.analyst_access_permission")
or request.user.has_perm("registrar.omb_analyst_access_permission")
or request.user.groups.filter(name="omb_analysts_group").exists()
):
return True
return super().has_change_permission(request, obj)

10
src/registrar/assets/src/js/getgov-admin/domain-request-form.js
View file

@ -465,23 +465,25 @@ class CustomizableEmailBase {
}
initializeModalConfirm() {
// When the modal confirm button is present, add a listener
if (this.modalConfirm) {
this.modalConfirm.addEventListener("click", () => {
this.textarea.removeAttribute('readonly');
this.textarea.focus();
hideElement(this.directEditButton);
hideElement(this.modalTrigger);
hideElement(this.directEditButton);
hideElement(this.modalTrigger);
});
}
}
initializeDirectEditButton() {
// When the direct edit button is present, add a listener
if (this.directEditButton) {
this.directEditButton.addEventListener("click", () => {
this.textarea.removeAttribute('readonly');
this.textarea.focus();
hideElement(this.directEditButton);
hideElement(this.modalTrigger);
hideElement(this.directEditButton);
hideElement(this.modalTrigger);
});
}
}

2
src/registrar/decorators.py
View file

@ -112,7 +112,7 @@ def _user_has_permission(user, request, rules, **kwargs):
permission_checks = [
(IS_STAFF, lambda: user.is_staff),
(IS_CISA_ANALYST, lambda: user.has_perm("registrar.analyst_access_permission")),
(IS_OMB_ANALYST, lambda: user.has_perm("registrar.omb_analyst_access_permission")),
(IS_OMB_ANALYST, lambda: user.groups.filter(name="omb_analysts_group").exists()),
(IS_FULL_ACCESS, lambda: user.has_perm("registrar.full_access_permission")),
(
IS_DOMAIN_MANAGER,

23
src/registrar/migrations/0144_alter_user_options.py
View file

@ -1,23 +0,0 @@
# Generated by Django 4.2.17 on 2025-03-06 20:00
from django.db import migrations
class Migration(migrations.Migration):
dependencies = [
("registrar", "0143_create_groups_v18"),
]
operations = [
migrations.AlterModelOptions(
name="user",
options={
"permissions": [
("analyst_access_permission", "Analyst Access Permission"),
("omb_analyst_access_permission", "OMB Analyst Access Permission"),
("full_access_permission", "Full Access Permission"),
]
},
),
]

1
src/registrar/models/user.py
View file

@ -40,7 +40,6 @@ class User(AbstractUser):
permissions = [
("analyst_access_permission", "Analyst Access Permission"),
("omb_analyst_access_permission", "OMB Analyst Access Permission"),
("full_access_permission", "Full Access Permission"),
]

5
src/registrar/models/user_group.py
View file

@ -158,11 +158,6 @@ class UserGroup(Group):
"model": "domain",
"permissions": ["view_domain"],
},
{
"app_label": "registrar",
"model": "user",
"permissions": ["omb_analyst_access_permission"],
},
{
"app_label": "registrar",
"model": "domaininvitation",