removed unnecessary permission

src/registrar/admin.py

@@ -4361,7 +4361,7 @@ class DomainAdmin(ListHeaderAdmin, ImportExportRegistrarModelAdmin):
         if (
             request.user.has_perm("registrar.full_access_permission")
             or request.user.has_perm("registrar.analyst_access_permission")
-            or request.user.has_perm("registrar.omb_analyst_access_permission")
+            or request.user.groups.filter(name="omb_analysts_group").exists()
         ):
             return True
         return super().has_change_permission(request, obj)

src/registrar/assets/src/js/getgov-admin/domain-request-form.js

@@ -465,23 +465,25 @@ class CustomizableEmailBase {
     }
 
     initializeModalConfirm() {
+        // When the modal confirm button is present, add a listener
         if (this.modalConfirm) {
             this.modalConfirm.addEventListener("click", () => {
                 this.textarea.removeAttribute('readonly');
                 this.textarea.focus();
-                    hideElement(this.directEditButton);
+                hideElement(this.directEditButton);
-                    hideElement(this.modalTrigger);  
+                hideElement(this.modalTrigger);  
             });
         }
     }
 
     initializeDirectEditButton() {
+        // When the direct edit button is present, add a listener
         if (this.directEditButton) {
             this.directEditButton.addEventListener("click", () => {
                 this.textarea.removeAttribute('readonly');
                 this.textarea.focus();
-                    hideElement(this.directEditButton);
+                hideElement(this.directEditButton);
-                    hideElement(this.modalTrigger);  
+                hideElement(this.modalTrigger);  
             });
         }
     }

src/registrar/decorators.py

@@ -112,7 +112,7 @@ def _user_has_permission(user, request, rules, **kwargs):
     permission_checks = [
         (IS_STAFF, lambda: user.is_staff),
         (IS_CISA_ANALYST, lambda: user.has_perm("registrar.analyst_access_permission")),
-        (IS_OMB_ANALYST, lambda: user.has_perm("registrar.omb_analyst_access_permission")),
+        (IS_OMB_ANALYST, lambda: user.groups.filter(name="omb_analysts_group").exists()),
         (IS_FULL_ACCESS, lambda: user.has_perm("registrar.full_access_permission")),
         (
             IS_DOMAIN_MANAGER,

src/registrar/migrations/0144_alter_user_options.py

@@ -1,23 +0,0 @@
-# Generated by Django 4.2.17 on 2025-03-06 20:00
-
-from django.db import migrations
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ("registrar", "0143_create_groups_v18"),
-    ]
-
-    operations = [
-        migrations.AlterModelOptions(
-            name="user",
-            options={
-                "permissions": [
-                    ("analyst_access_permission", "Analyst Access Permission"),
-                    ("omb_analyst_access_permission", "OMB Analyst Access Permission"),
-                    ("full_access_permission", "Full Access Permission"),
-                ]
-            },
-        ),
-    ]

src/registrar/models/user.py

@@ -40,7 +40,6 @@ class User(AbstractUser):
 
         permissions = [
             ("analyst_access_permission", "Analyst Access Permission"),
-            ("omb_analyst_access_permission", "OMB Analyst Access Permission"),
             ("full_access_permission", "Full Access Permission"),
         ]
 

src/registrar/models/user_group.py

@@ -158,11 +158,6 @@ class UserGroup(Group):
                 "model": "domain",
                 "permissions": ["view_domain"],
             },
-            {
-                "app_label": "registrar",
-                "model": "user",
-                "permissions": ["omb_analyst_access_permission"],
-            },
             {
                 "app_label": "registrar",
                 "model": "domaininvitation",