zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-15 17:17:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix paginator row overwrite bug

Browse source
This commit is contained in:
Rachid Mrad 2024-03-21 18:22:49 -04:00
parent 4c234158e1
commit 4fe6b83f29
No known key found for this signature in database
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/utility/csv_export.py
View file

@ -254,6 +254,7 @@ def write_requests_csv(
# Reduce the memory overhead when performing the write operation # Reduce the memory overhead when performing the write operation
paginator = Paginator(all_requests, 1000) paginator = Paginator(all_requests, 1000)
total_body_rows = []
for page_num in paginator.page_range: for page_num in paginator.page_range:
page = paginator.page(page_num) page = paginator.page(page_num)
@ -267,10 +268,11 @@ def write_requests_csv(
# It indicates that DomainInformation.domain is None. # It indicates that DomainInformation.domain is None.
logger.error("csv_export -> Error when parsing row, domain was None") logger.error("csv_export -> Error when parsing row, domain was None")
continue continue
total_body_rows.extend(rows)
if should_write_header: if should_write_header:
write_header(writer, columns) write_header(writer, columns)
writer.writerows(rows) writer.writerows(total_body_rows)
def export_data_type_to_csv(csv_file): def export_data_type_to_csv(csv_file):