From f91b8cdd91ce7ffd2123736522b0a33128c3fe18 Mon Sep 17 00:00:00 2001
From: Rachid Mrad <rachid.mrad@ecstech.com>
Date: Mon, 20 May 2024 16:00:58 -0400
Subject: [PATCH] fix url

---
 src/registrar/forms/user_profile.py              |  1 -
 src/registrar/templates/domain_detail.html       |  1 +
 src/registrar/templates/domain_sidebar.html      |  2 +-
 .../templates/includes/input_with_errors.html    |  8 ++++----
 src/registrar/templates/profile.html             | 16 +++++++++-------
 5 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/src/registrar/forms/user_profile.py b/src/registrar/forms/user_profile.py
index 036b03751..31e26a5a6 100644
--- a/src/registrar/forms/user_profile.py
+++ b/src/registrar/forms/user_profile.py
@@ -55,6 +55,5 @@ class UserProfileForm(forms.ModelForm):
             "required": "Enter your email address in the required format, like name@example.com."
         }
         self.fields["phone"].error_messages["required"] = "Enter your phone number."
-        self.domainInfo = None
 
         DomainHelper.disable_field(self.fields["email"], disable_required=True)
diff --git a/src/registrar/templates/domain_detail.html b/src/registrar/templates/domain_detail.html
index 67837196f..815df4942 100644
--- a/src/registrar/templates/domain_detail.html
+++ b/src/registrar/templates/domain_detail.html
@@ -59,6 +59,7 @@
     {% url 'domain-authorizing-official' pk=domain.id as url %}
     {% include "includes/summary_item.html" with title='Authorizing official' value=domain.domain_info.authorizing_official contact='true' edit_link=url editable=domain.is_editable %}
 
+    {# Conditionally display profile #}
     {% if not has_profile_feature_flag %}
     {% url 'domain-your-contact-information' pk=domain.id as url %}
     {% include "includes/summary_item.html" with title='Your contact information' value=request.user.contact contact='true' edit_link=url editable=domain.is_editable %}
diff --git a/src/registrar/templates/domain_sidebar.html b/src/registrar/templates/domain_sidebar.html
index f99cfd0cf..5739d0417 100644
--- a/src/registrar/templates/domain_sidebar.html
+++ b/src/registrar/templates/domain_sidebar.html
@@ -74,7 +74,7 @@
       </li>
 
       {% if not has_profile_feature_flag %}
-      {% comment %}Conditionally display profile link in main nav{% endcomment %}
+      {# Conditionally display profile link in main nav #}
       <li class="usa-sidenav__item">
         {% url 'domain-your-contact-information' pk=domain.id as url %}
         <a href="{{ url }}"
diff --git a/src/registrar/templates/includes/input_with_errors.html b/src/registrar/templates/includes/input_with_errors.html
index e47c9cc53..2c25d8a76 100644
--- a/src/registrar/templates/includes/input_with_errors.html
+++ b/src/registrar/templates/includes/input_with_errors.html
@@ -32,12 +32,12 @@ error messages, if necessary.
 
   {% if sublabel_text %}
     <p id="{{ widget.attrs.id }}__sublabel" class="text-base margin-top-2px margin-bottom-1">
-      {% comment %} If the link_text appears more than once, the first instance will be a link and the other instances will be ignored {% endcomment %}
+      {# If the link_text appears more than once, the first instance will be a link and the other instances will be ignored #}
       {% if link_text and link_text in sublabel_text %}
         {% with link_index=sublabel_text|find_index:link_text %}
           {{ sublabel_text|slice:link_index }}
-          {% comment %} HTML will convert a new line into a space, resulting with a space before the fullstop in case link_text is at the end of sublabel_text, hence the unfortunate line below {% endcomment %}
-          <a {% if external_link == "true" %}rel="noopener noreferrer" class="usa-link usa-link--external" {% endif %}{% if target_blank == "true" %}target="_blank" {% endif %}href="{{ link_href }}">{{ link_text }}</a>{% with sublabel_part_after=sublabel_text|slice_after:link_text %}{{ sublabel_part_after }}{% endwith %}
+          {# HTML will convert a new line into a space, resulting with a space before the fullstop in case link_text is at the end of sublabel_text, hence the unfortunate line below #}
+          <a {% if external_link %}rel="noopener noreferrer" class="usa-link usa-link--external" {% endif %}{% if target_blank == "true" %}target="_blank" {% endif %}href="{{ link_href }}">{{ link_text }}</a>{% with sublabel_part_after=sublabel_text|slice_after:link_text %}{{ sublabel_part_after }}{% endwith %}
         {% endwith %}
       {% else %}
         {{ sublabel_text }}
@@ -76,7 +76,7 @@ error messages, if necessary.
   </div>
 {% endif %}
 
-{% if widget.attrs.maxlength and do_not_show_max_chars == "false" %}
+{% if widget.attrs.maxlength and not do_not_show_max_chars %}
   <span
     id="{{ widget.attrs.id }}__message"
     class="usa-character-count__message"
diff --git a/src/registrar/templates/profile.html b/src/registrar/templates/profile.html
index a9befe397..70081698c 100644
--- a/src/registrar/templates/profile.html
+++ b/src/registrar/templates/profile.html
@@ -50,17 +50,19 @@ Edit your User Profile |
         {% input_with_errors form.last_name %}
     
         {% input_with_errors form.title %}
-    
-        {% with sublabel_text="We recommend using your work email for your .gov account. If the wrong email is displayed below, you’ll need to update your Login.gov account and log back in. Get help with your Login.gov account." %}
-          {% with link_text="Get help with your Login.gov account" %}
-            {% with link_href="http://Login.gov" %}
-              {% with target_blank="true" %}
-                {% with do_not_show_max_chars="true" %}
+
+        {% public_site_url "help/account-management/#get-help-with-login.gov" as login_help_url %}
+
+        {% with link_href=login_help_url %}
+          {% with sublabel_text="We recommend using your work email for your .gov account. If the wrong email is displayed below, you’ll need to update your Login.gov account and log back in. Get help with your Login.gov account." %}
+            {% with link_text="Get help with your Login.gov account" %}
+              {% with target_blank=True %}
+                {% with do_not_show_max_chars=True %}
                   {% input_with_errors form.email %}
                 {% endwith %}
               {% endwith %}
             {% endwith %}
-          {% endwith %}  
+          {% endwith %}
         {% endwith %}
     
         {% with add_class="usa-input--medium" %}