From 4e1797a28055d4d540aa9f95aaaf7e077fd51bc1 Mon Sep 17 00:00:00 2001 From: CocoByte Date: Thu, 5 Dec 2024 13:03:55 -0700 Subject: [PATCH] remove maxDiff = None --- src/registrar/tests/test_admin_request.py | 2 -- src/registrar/tests/test_migrations.py | 1 - src/registrar/tests/test_reports.py | 9 --------- 3 files changed, 12 deletions(-) diff --git a/src/registrar/tests/test_admin_request.py b/src/registrar/tests/test_admin_request.py index 025c80363..d2e4c1c1b 100644 --- a/src/registrar/tests/test_admin_request.py +++ b/src/registrar/tests/test_admin_request.py @@ -1693,7 +1693,6 @@ class TestDomainRequestAdmin(MockEppLib): "notes", "alternative_domains", ] - self.maxDiff = None self.assertEqual(readonly_fields, expected_fields) def test_readonly_fields_for_analyst(self): @@ -1702,7 +1701,6 @@ class TestDomainRequestAdmin(MockEppLib): request.user = self.staffuser readonly_fields = self.admin.get_readonly_fields(request) - self.maxDiff = None expected_fields = [ "portfolio_senior_official", "portfolio_organization_type", diff --git a/src/registrar/tests/test_migrations.py b/src/registrar/tests/test_migrations.py index eaaae8727..11daca870 100644 --- a/src/registrar/tests/test_migrations.py +++ b/src/registrar/tests/test_migrations.py @@ -63,7 +63,6 @@ class TestGroups(TestCase): # Get the codenames of actual permissions associated with the group actual_permissions = [p.codename for p in cisa_analysts_group.permissions.all()] - self.maxDiff = None # Assert that the actual permissions match the expected permissions self.assertListEqual(actual_permissions, expected_permissions) diff --git a/src/registrar/tests/test_reports.py b/src/registrar/tests/test_reports.py index 4a868a794..d801ce76a 100644 --- a/src/registrar/tests/test_reports.py +++ b/src/registrar/tests/test_reports.py @@ -280,7 +280,6 @@ class ExportDataTest(MockDbForIndividualTests, MockEppLib): # spaces and leading/trailing whitespace csv_content = csv_content.replace(",,", "").replace(",", "").replace(" ", "").replace("\r\n", "\n").strip() expected_content = expected_content.replace(",,", "").replace(",", "").replace(" ", "").strip() - self.maxDiff = None self.assertEqual(csv_content, expected_content) @less_console_noise_decorator @@ -327,7 +326,6 @@ class ExportDataTest(MockDbForIndividualTests, MockEppLib): # spaces and leading/trailing whitespace csv_content = csv_content.replace(",,", "").replace(",", "").replace(" ", "").replace("\r\n", "\n").strip() expected_content = expected_content.replace(",,", "").replace(",", "").replace(" ", "").strip() - self.maxDiff = None self.assertEqual(csv_content, expected_content) @less_console_noise_decorator @@ -506,7 +504,6 @@ class ExportDataTest(MockDbForIndividualTests, MockEppLib): # spaces and leading/trailing whitespace csv_content = csv_content.replace(",,", "").replace(",", "").replace(" ", "").replace("\r\n", "\n").strip() expected_content = expected_content.replace(",,", "").replace(",", "").replace(" ", "").strip() - self.maxDiff = None self.assertEqual(csv_content, expected_content) @less_console_noise_decorator @@ -546,14 +543,12 @@ class ExportDataTest(MockDbForIndividualTests, MockEppLib): # spaces and leading/trailing whitespace csv_content = csv_content.replace(",,", "").replace(",", "").replace(" ", "").replace("\r\n", "\n").strip() expected_content = expected_content.replace(",,", "").replace(",", "").replace(" ", "").strip() - self.maxDiff = None self.assertEqual(csv_content, expected_content) @less_console_noise_decorator def test_domain_growth(self): """Shows ready and deleted domains within a date range, sorted""" # Remove "Created at" and "First ready" because we can't guess this immutable, dynamically generated test data - self.maxDiff = None columns = [ "Domain name", "Domain type", @@ -616,7 +611,6 @@ class ExportDataTest(MockDbForIndividualTests, MockEppLib): squeaker@rocks.com is invited to domain2 (DNS_NEEDED) and domain10 (No managers). She should show twice in this report but not in test_DomainManaged.""" - self.maxDiff = None # Create a CSV file in memory csv_file = StringIO() # Call the export functions @@ -651,7 +645,6 @@ class ExportDataTest(MockDbForIndividualTests, MockEppLib): # spaces and leading/trailing whitespace csv_content = csv_content.replace(",,", "").replace(",", "").replace(" ", "").replace("\r\n", "\n").strip() expected_content = expected_content.replace(",,", "").replace(",", "").replace(" ", "").strip() - self.maxDiff = None self.assertEqual(csv_content, expected_content) @less_console_noise_decorator @@ -729,7 +722,6 @@ class ExportDataTest(MockDbForIndividualTests, MockEppLib): # @less_console_noise_decorator def test_domain_request_data_full(self): - self.maxDiff = None """Tests the full domain request report.""" # Remove "Submitted at" because we can't guess this immutable, dynamically generated test data columns = [ @@ -865,7 +857,6 @@ class MemberExportTest(MockDbForIndividualTests, MockEppLib): # Create a request and add the user to the request request = self.factory.get("/") request.user = self.user - self.maxDiff = None # Add portfolio to session request = GenericTestHelper._mock_user_request_for_factory(request) request.session["portfolio"] = self.portfolio_1