zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-12 12:39:43 +02:00
Code Issues Projects Releases Packages Wiki Activity

test simpler way to organize which emails to send

Browse source
This commit is contained in:
matthewswspence 2024-09-19 15:34:50 -05:00
parent f254e0441f
commit 4ce28fd18b
No known key found for this signature in database
GPG key ID: FB458202A7852BA4
1 changed files with 54 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

93
src/registrar/views/domain.py
View file

@ -110,6 +110,22 @@ class DomainFormBaseView(DomainBaseView, FormMixin):
implementations of post, form_valid and form_invalid. implementations of post, form_valid and form_invalid.
""" """
# send notification email for changes to any of these forms
notify_on_change = (
DomainSecurityEmailForm,
DomainDnssecForm,
DomainDsdataFormset,
)
# forms of these types should not send notifications if they're part of a portfolio/Organization
notify_unless_portfolio = (
DomainOrgNameAddressForm,
SeniorOfficialContactForm
)
def should_notify(self, form) -> bool:
return isinstance(form, self.notify_on_change) or isinstance(form, self.notify_unless_portfolio)
def post(self, request, *args, **kwargs): def post(self, request, *args, **kwargs):
"""Form submission posts to this view. """Form submission posts to this view.
@ -126,6 +142,13 @@ class DomainFormBaseView(DomainBaseView, FormMixin):
# updates session cache with domain # updates session cache with domain
self._update_session_with_domain() self._update_session_with_domain()
if self.should_notify(form):
logger.info("Sending email to domain managers")
context={
"domain": self.object,
}
self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context)
# superclass has the redirect # superclass has the redirect
return super().form_valid(form) return super().form_valid(form)
@ -262,13 +285,6 @@ class DomainOrgNameAddressView(DomainFormBaseView):
def form_valid(self, form): def form_valid(self, form):
"""The form is valid, save the organization name and mailing address.""" """The form is valid, save the organization name and mailing address."""
if form.has_changed():
logger.info("Sending email to domain managers")
context={
"domain": self.object,
}
self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context)
form.save() form.save()
messages.success(self.request, "The organization information for this domain has been updated.") messages.success(self.request, "The organization information for this domain has been updated.")
@ -369,12 +385,12 @@ class DomainSeniorOfficialView(DomainFormBaseView):
# Set the domain information in the form so that it can be accessible # Set the domain information in the form so that it can be accessible
# to associate a new Contact, if a new Contact is needed # to associate a new Contact, if a new Contact is needed
# in the save() method # in the save() method
if form.has_changed(): # if form.has_changed():
logger.info("Sending email to domain managers") # logger.info("Sending email to domain managers")
context={ # context={
"domain": self.object, # "domain": self.object,
} # }
self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context) # self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context)
form.set_domain_info(self.object.domain_info) form.set_domain_info(self.object.domain_info)
@ -526,13 +542,12 @@ class DomainNameserversView(DomainFormBaseView):
messages.error(self.request, NameserverError(code=nsErrorCodes.BAD_DATA)) messages.error(self.request, NameserverError(code=nsErrorCodes.BAD_DATA))
logger.error(f"Registry error: {Err}") logger.error(f"Registry error: {Err}")
else: else:
if form.has_changed(): # if form.has_changed():
logger.info("Sending email to domain managers") # logger.info("Sending email to domain managers")
context={ # context={
"domain": self.object, # "domain": self.object,
} # }
self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context) # self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context)
messages.success( messages.success(
self.request, self.request,
@ -586,13 +601,13 @@ class DomainDNSSECView(DomainFormBaseView):
errmsg = "Error removing existing DNSSEC record(s)." errmsg = "Error removing existing DNSSEC record(s)."
logger.error(errmsg + ": " + err) logger.error(errmsg + ": " + err)
messages.error(self.request, errmsg) messages.error(self.request, errmsg)
else: # else:
if form.has_changed(): # if form.has_changed():
logger.info("Sending email to domain managers") # logger.info("Sending email to domain managers")
context={ # context={
"domain": self.object, # "domain": self.object,
} # }
self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context) # self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context)
return self.form_valid(form) return self.form_valid(form)
@ -717,12 +732,12 @@ class DomainDsDataView(DomainFormBaseView):
logger.error(f"Registry error: {err}") logger.error(f"Registry error: {err}")
return self.form_invalid(formset) return self.form_invalid(formset)
else: else:
if form.has_changed(): # if formset.has_changed():
logger.info("Sending email to domain managers") # logger.info("Sending email to domain managers")
context={ # context={
"domain": self.object, # "domain": self.object,
} # }
self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context) # self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context)
messages.success(self.request, "The DS data records for this domain have been updated.") messages.success(self.request, "The DS data records for this domain have been updated.")
# superclass has the redirect # superclass has the redirect
@ -822,12 +837,12 @@ class DomainSecurityEmailView(DomainFormBaseView):
messages.error(self.request, SecurityEmailError(code=SecurityEmailErrorCodes.BAD_DATA)) messages.error(self.request, SecurityEmailError(code=SecurityEmailErrorCodes.BAD_DATA))
logger.error(f"Generic registry error: {Err}") logger.error(f"Generic registry error: {Err}")
else: else:
if form.has_changed(): # if form.has_changed():
logger.info("Sending email to domain managers") # logger.info("Sending email to domain managers")
context={ # context={
"domain": self.object, # "domain": self.object,
} # }
self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context) # self.email_domain_managers(self.object, "emails/domain_change_notification.txt", "emails/domain_change_notification_subject.txt", context)
messages.success(self.request, "The security email for this domain has been updated.") messages.success(self.request, "The security email for this domain has been updated.")