zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-05 17:28:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

comments clean up

Browse source
This commit is contained in:
Rachid Mrad 2023-10-10 20:02:02 -04:00
parent 45429eef71
commit 4c2eaac59f
No known key found for this signature in database
GPG key ID: EF38E4CEC4A8F3CF
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/registrar/views/domain.py
View file

@ -297,6 +297,8 @@ class DomainDsdataView(DomainPermissionView, FormMixin):
if dnssecdata is not None:
if dnssecdata.keyData is not None:
# TODO: Throw an error
# Note: This is moot if we're
# removing key data
pass
if dnssecdata.dsData is not None:
@ -311,7 +313,7 @@ class DomainDsdataView(DomainPermissionView, FormMixin):
for record in dnssecdata.dsData
)
# Ensure at least 3 fields, filled or empty
# Ensure at least 1 record, filled or empty
while len(initial_data) == 0:
initial_data.append({})
@ -385,7 +387,6 @@ class DomainDsdataView(DomainPermissionView, FormMixin):
try:
domain.dnssecdata = dnssecdata
except RegistryError as err:
# Alysia: Check client hold error handling and duplicate this here
errmsg = "Error updating DNSSEC data in the registry."
logger.error(errmsg)
logger.error(err)
@ -415,7 +416,9 @@ class DomainKeydataView(DomainPermissionView, FormMixin):
if dnssecdata is not None:
if dnssecdata.dsData is not None:
# TODO: Throw an error
# TODO: Throw an error?
# Note: this is moot if we're
# removing Key data
pass
if dnssecdata.keyData is not None:
@ -430,7 +433,7 @@ class DomainKeydataView(DomainPermissionView, FormMixin):
for record in dnssecdata.keyData
)
# Ensure at least 3 fields, filled or empty
# Ensure at least 1 record, filled or empty
while len(initial_data) == 0:
initial_data.append({})