zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-19 02:49:21 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug with anything else form

Browse source
This commit is contained in:
zandercymatics 2024-04-16 09:17:39 -06:00
parent 6ee8e05923
commit 46c0d846b6
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/registrar/views/domain_request.py
View file

@ -585,13 +585,8 @@ class OtherContacts(DomainRequestWizard):
# DONE-NL: rename this to "Additional Details" (note: this is a find-replace job. VS will not refactor properly) # DONE-NL: rename this to "Additional Details" (note: this is a find-replace job. VS will not refactor properly)
class AdditionalDetails(DomainRequestWizard): class AdditionalDetails(DomainRequestWizard):
# TODO-NL: Delete this old (original code for anything else)
# template_name = "domain_request_anything_else.html"
# forms = [forms.AdditionalDetailsForm]
template_name = "domain_request_additional_details.html" template_name = "domain_request_additional_details.html"
# OLD: forms = [forms.OtherContactsYesNoForm, forms.OtherContactsFormSet, forms.NoOtherContactsForm]
# TODO-NL: (refactor) -- move form hookups into respective areas
forms = [ forms = [
forms.CisaRepresentativeYesNoForm, forms.CisaRepresentativeYesNoForm,
forms.CisaRepresentativeForm, forms.CisaRepresentativeForm,
@ -599,7 +594,6 @@ class AdditionalDetails(DomainRequestWizard):
forms.AdditionalDetailsForm, forms.AdditionalDetailsForm,
] ]
# TODO-NL: (refactor) -- move validation into respective areas
def is_valid(self, forms: list) -> bool: def is_valid(self, forms: list) -> bool:
# Validate Cisa Representative # Validate Cisa Representative
@ -637,7 +631,7 @@ class AdditionalDetails(DomainRequestWizard):
# mark the anything_else_form for deletion # mark the anything_else_form for deletion
anything_else_form.mark_form_for_deletion() anything_else_form.mark_form_for_deletion()
else: else:
anything_else_portion_is_valid = cisa_representative_email_form.is_valid() anything_else_portion_is_valid = anything_else_form.is_valid()
else: else:
# if yes no form is invalid, no choice has been made # if yes no form is invalid, no choice has been made
# mark the anything_else_form for deletion # mark the anything_else_form for deletion