zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-16 17:47:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

optimize by removing filters from inside iterations

Browse source
This commit is contained in:
Rachid Mrad 2024-04-01 21:35:29 -04:00
parent 8c8d7b6b63
commit 45c047dc8a
No known key found for this signature in database
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/utility/csv_export.py
View file

@ -107,7 +107,7 @@ def parse_domain_row(columns, domain_info: DomainInformation, security_emails_di
# Get lists of emails for active and invited domain managers
dm_active_emails = [dm.user.email for dm in domain.permissions.all()]
dm_invited_emails = [
invite.email for invite in invites_with_invited_status.filter(domain=domain)
invite.email for invite in invites_with_invited_status if invite.domain_id == domain_info.domain_id
]
# Set up the "matching headers" + row field data for email and status
@ -160,7 +160,7 @@ def update_columns_with_domain_managers(
Updated update_columns, columns, max_dm_active, max_dm_invited, max_dm_total"""
dm_active = domain_info.domain.permissions.count()
dm_invited = invites_with_invited_status.filter(domain=domain_info.domain).count()
dm_invited = sum(1 for invite in invites_with_invited_status if invite.domain_id == domain_info.domain_id)
if dm_active + dm_invited > max_dm_total:
max_dm_total = dm_active + dm_invited