zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-13 21:19:42 +02:00
Code Issues Projects Releases Packages Wiki Activity

linter fixes

Browse source
This commit is contained in:
matthewswspence 2025-03-13 12:19:58 -05:00
parent 48d025019f
commit 44da71b007
No known key found for this signature in database
GPG key ID: FB458202A7852BA4
4 changed files with 32 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/registrar/forms/domain_request_wizard.py
View file

@ -616,7 +616,8 @@ class PurposeDetailsForm(BaseDeletableRegistrarForm):
label="Purpose", label="Purpose",
widget=forms.Textarea( widget=forms.Textarea(
attrs={ attrs={
"aria-label": "What is the purpose of your requested domain? Describe how you’ll use your .gov domain. \ "aria-label": "What is the purpose of your requested domain? \
Describe how you’ll use your .gov domain. \
Will it be used for a website, email, or something else?" Will it be used for a website, email, or something else?"
} }
), ),
@ -873,28 +874,6 @@ class CisaRepresentativeYesNoForm(BaseYesNoForm):
field_name = "has_cisa_representative" field_name = "has_cisa_representative"
class PurposeDetailsForm(BaseDeletableRegistrarForm):
field_name = "purpose"
purpose = forms.CharField(
label="Purpose",
widget=forms.Textarea(
attrs={
"aria-label": "What is the purpose of your requested domain? Describe how you’ll use your .gov domain. \
Will it be used for a website, email, or something else?"
}
),
validators=[
MaxLengthValidator(
2000,
message="Response must be less than 2000 characters.",
)
],
error_messages={"required": "Describe how you’ll use the .gov domain you’re requesting."},
)
class AnythingElseForm(BaseDeletableRegistrarForm): class AnythingElseForm(BaseDeletableRegistrarForm):
anything_else = forms.CharField( anything_else = forms.CharField(
required=True, required=True,

1
src/registrar/forms/feb.py
View file

@ -3,6 +3,7 @@ from django.core.validators import MaxLengthValidator
from registrar.forms.utility.wizard_form_helper import BaseDeletableRegistrarForm, BaseYesNoForm from registrar.forms.utility.wizard_form_helper import BaseDeletableRegistrarForm, BaseYesNoForm
from registrar.models.contact import Contact from registrar.models.contact import Contact
class ExecutiveNamingRequirementsYesNoForm(BaseYesNoForm, BaseDeletableRegistrarForm): class ExecutiveNamingRequirementsYesNoForm(BaseYesNoForm, BaseDeletableRegistrarForm):
""" """
Form for verifying if the domain request meets the Federal Executive Branch domain naming requirements. Form for verifying if the domain request meets the Federal Executive Branch domain naming requirements.

14
src/registrar/tests/test_views_request.py
View file

@ -2718,12 +2718,20 @@ class DomainRequestTests(TestWithUser, WebTest):
def feb_requirements_page_tests(self, requirements_page): def feb_requirements_page_tests(self, requirements_page):
# Check for the 21st Century IDEA Act links # Check for the 21st Century IDEA Act links
self.assertContains(requirements_page, "https://digital.gov/resources/delivering-digital-first-public-experience-act/") self.assertContains(
self.assertContains(requirements_page, "https://bidenwhitehouse.gov/wp-content/uploads/2023/09/M-23-22-Delivering-a-Digital-First-Public-Experience.pdf") requirements_page, "https://digital.gov/resources/delivering-digital-first-public-experience-act/"
)
self.assertContains(
requirements_page,
"https://bidenwhitehouse.gov/wp-content/uploads/2023/09/M-23-22-Delivering-a-Digital-First-Public-Experience.pdf", # noqa
)
# Check for the policy acknowledgement form # Check for the policy acknowledgement form
self.assertContains(requirements_page, "is_policy_acknowledged") self.assertContains(requirements_page, "is_policy_acknowledged")
self.assertContains(requirements_page, "I read and understand the guidance outlined in the DOTGOV Act for operating a .gov domain.") self.assertContains(
requirements_page,
"I read and understand the guidance outlined in the DOTGOV Act for operating a .gov domain.",
)
@less_console_noise_decorator @less_console_noise_decorator
def test_domain_request_formsets(self): def test_domain_request_formsets(self):

14
src/registrar/views/domain_request.py
View file

@ -642,10 +642,12 @@ class PortfolioAdditionalDetails(DomainRequestWizard):
anything_else_forms_valid = False anything_else_forms_valid = False
if forms[2].cleaned_data.get("has_anything_else_text"): if forms[2].cleaned_data.get("has_anything_else_text"):
forms[3].fields["anything_else"].required = True forms[3].fields["anything_else"].required = True
forms[3].fields["anything_else"].error_messages["required"] = "Please provide additional details you'd like us to know. \ forms[3].fields["anything_else"].error_messages[
"required"
] = "Please provide additional details you'd like us to know. \
If you have nothing to add, select 'No'." If you have nothing to add, select 'No'."
anything_else_forms_valid = forms[3].is_valid() anything_else_forms_valid = forms[3].is_valid()
return (eop_forms_valid and anything_else_forms_valid) return eop_forms_valid and anything_else_forms_valid
# Non-portfolio pages # Non-portfolio pages
@ -942,9 +944,13 @@ class Requirements(DomainRequestWizard):
for form in forms_list: for form in forms_list:
if isinstance(form, forms.RequirementsForm): if isinstance(form, forms.RequirementsForm):
if self.requires_feb_questions(): if self.requires_feb_questions():
form.fields['is_policy_acknowledged'].label = "I read and understand the guidance outlined in the DOTGOV Act for operating a .gov domain." # noqa: E501 form.fields["is_policy_acknowledged"].label = (
"I read and understand the guidance outlined in the DOTGOV Act for operating a .gov domain." # noqa: E501
)
else: else:
form.fields['is_policy_acknowledged'].label = "I read and agree to the requirements for operating a .gov domain." # noqa: E501 form.fields["is_policy_acknowledged"].label = (
"I read and agree to the requirements for operating a .gov domain." # noqa: E501
)
return forms_list return forms_list