zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-23 03:06:01 +02:00
Code Issues Projects Releases Packages Wiki Activity

form level error handling at the field level

Browse source
This commit is contained in:
David Kennedy 2023-10-19 17:26:26 -04:00
parent 150e89d2ee
commit 43b6d1e380
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
2 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/registrar/models/domain.py
View file

@ -314,7 +314,6 @@ class Domain(TimeStampedModel, DomainHelper):
NameserverError (if exception hit)
Returns:
None"""
logger.info("checkHostIPCombo is called on %s, %s", name, nameserver)
if cls.isSubdomain(name, nameserver) and (ip is None or ip == [] or ip == ['']):
raise NameserverError(code=nsErrorCodes.MISSING_IP, nameserver=nameserver)
@ -330,7 +329,6 @@ class Domain(TimeStampedModel, DomainHelper):
raise NameserverError(
code=nsErrorCodes.INVALID_IP, nameserver=nameserver, ip=ip
)
logger.info("got no errors")
return None
@classmethod
@ -340,7 +338,6 @@ class Domain(TimeStampedModel, DomainHelper):
returns:
isValid (boolean)-True for valid ip address"""
try:
logger.info(f"in valid_ip_addr: {ipToTest}")
ip = ipaddress.ip_address(ipToTest)
logger.info(ip.version)
return ip.version == 6 or ip.version == 4