zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-17 15:04:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

cleaned up dsdata form

Browse source
This commit is contained in:
David Kennedy 2023-10-04 15:33:04 -04:00
parent 945c54adc7
commit 41ce73ff4b
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 6 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

38
src/registrar/forms/domain.py
View file

@ -148,13 +148,7 @@ class DomainDnssecForm(forms.Form):
class DomainDsdataForm(forms.Form): class DomainDsdataForm(forms.Form):
"""Form for adding or editing a security email to a domain.""" """Form for adding or editing DNSSEC DS Data to a domain."""
# TODO: ds key data
# has_ds_key_data = forms.TypedChoiceField(
# required=True,
# label="DS Data record type",
# choices=[(False, "DS Data"), (True, "DS Data with Key Data")],
# )
key_tag = forms.IntegerField( key_tag = forms.IntegerField(
required=True, required=True,
@ -164,45 +158,25 @@ class DomainDsdataForm(forms.Form):
MaxValueValidator(65535, "Value must be between 0 and 65535"), MaxValueValidator(65535, "Value must be between 0 and 65535"),
], ],
) )
algorithm = forms.TypedChoiceField( algorithm = forms.TypedChoiceField(
required=True, required=True,
label="Algorithm", label="Algorithm",
choices=[(None, "--Select--")] + ALGORITHM_CHOICES, choices=[(None, "--Select--")] + ALGORITHM_CHOICES,
# Q: Is this even needed or is a required=True sufficient?
# error_messages={
# "required": (
# "You must select an Algorithm"
# )
# },
) )
# Q: Is ChoiceFiled right? Or do we need to data types other than strings
# (TypedChoiceField)
digest_type = forms.TypedChoiceField( digest_type = forms.TypedChoiceField(
required=True, required=True,
label="Digest Type", label="Digest Type",
choices=[(None, "--Select--")] + DIGEST_TYPE_CHOICES, choices=[(None, "--Select--")] + DIGEST_TYPE_CHOICES,
# Q: Is this even needed or is a required=True sufficient?
# error_messages={
# "required": (
# "You must select a Digest Type"
# )
# },
) )
digest = forms.CharField( digest = forms.CharField(
required=True, required=True,
label="Digest", label="Digest",
# validators=[ # TODO: Validation of digests in registrar?
# RegexValidator(
# "^[0-9]{5}(?:-[0-9]{4})?$|^$",
# message="Accepted range 0-65535.",
# )
# ],
) )
# TODO: Conditional DS Key Data fields
DomainDsdataFormset = formset_factory( DomainDsdataFormset = formset_factory(
DomainDsdataForm, DomainDsdataForm,
@ -211,7 +185,7 @@ DomainDsdataFormset = formset_factory(
class DomainKeydataForm(forms.Form): class DomainKeydataForm(forms.Form):
"""Form for adding or editing DNSSEC key data.""" """Form for adding or editing DNSSEC Key Data to a domain."""
flag = forms.TypedChoiceField( flag = forms.TypedChoiceField(
required=True, required=True,