zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-16 22:44:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

PR suggestions (minus unit test)

Browse source
This commit is contained in:
zandercymatics 2024-08-14 10:53:57 -06:00
parent b89ae53c84
commit 413bb53664
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
1 changed files with 23 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

42
src/registrar/assets/js/get-gov-admin.js
View file

@ -511,16 +511,15 @@ function initializeWidgetOnList(list, parentId) {
var actionNeededReasonDropdown = document.querySelector("#id_action_needed_reason"); var actionNeededReasonDropdown = document.querySelector("#id_action_needed_reason");
var actionNeededEmail = document.querySelector("#id_action_needed_reason_email"); var actionNeededEmail = document.querySelector("#id_action_needed_reason_email");
var readonlyView = document.querySelector("#action-needed-reason-email-readonly"); var readonlyView = document.querySelector("#action-needed-reason-email-readonly");
if(!actionNeededEmail || !actionNeededReasonDropdown) {
return;
}
let emailWasSent = document.getElementById("action-needed-email-sent"); let emailWasSent = document.getElementById("action-needed-email-sent");
if (!emailWasSent) {
let emailData = document.getElementById('action-needed-emails-data');
if (!emailData) {
return; return;
} }
let actionNeededEmailData = document.getElementById('action-needed-emails-data').textContent; let actionNeededEmailData = emailData.textContent;
if(!actionNeededEmailData) { if(!actionNeededEmailData) {
return; return;
} }
@ -762,20 +761,20 @@ function initializeWidgetOnList(list, parentId) {
})(); })();
/** An IIFE for copy summary button (appears in DomainRegistry models) /** An IIFE for dynamically changing some fields on the portfolio admin model
*/ */
(function dynamicPortfolioFields(){ (function dynamicPortfolioFields(){
document.addEventListener('DOMContentLoaded', function() { document.addEventListener('DOMContentLoaded', function() {
let isPortfolioPage = document.querySelector("#portfolio_form"); let isPortfolioPage = document.getElementById("portfolio_form");
if (!isPortfolioPage) { if (!isPortfolioPage) {
return; return;
} }
// $ symbolically denotes that this is using jQuery // $ symbolically denotes that this is using jQuery
let $federalAgency = django.jQuery("#id_federal_agency"); let $federalAgency = django.jQuery("#id_federal_agency");
let organizationType = document.querySelector("#id_organization_type"); let organizationType = document.getElementById("id_organization_type");
if ($federalAgency && organizationType) { if ($federalAgency && organizationType) {
// Execute this function once on load // Execute this function once on load
handleFederalAgencyChange($federalAgency, organizationType); handleFederalAgencyChange($federalAgency, organizationType);
@ -788,7 +787,7 @@ function initializeWidgetOnList(list, parentId) {
// Handle dynamically hiding the urbanization field // Handle dynamically hiding the urbanization field
let urbanizationField = document.querySelector(".field-urbanization"); let urbanizationField = document.querySelector(".field-urbanization");
let stateTerritory = document.querySelector("#id_state_territory"); let stateTerritory = document.getElementById("id_state_territory");
if (urbanizationField && stateTerritory) { if (urbanizationField && stateTerritory) {
// Execute this function once on load // Execute this function once on load
handleStateTerritoryChange(stateTerritory, urbanizationField); handleStateTerritoryChange(stateTerritory, urbanizationField);
@ -803,17 +802,20 @@ function initializeWidgetOnList(list, parentId) {
function handleFederalAgencyChange(federalAgency, organizationType) { function handleFederalAgencyChange(federalAgency, organizationType) {
// Set the org type to federal if an agency is selected // Set the org type to federal if an agency is selected
let selectedText = federalAgency.find("option:selected").text(); let selectedText = federalAgency.find("option:selected").text();
if (selectedText !== "Non-Federal Agency" && selectedText) {
// There isn't a federal senior official associated with null records
if (!selectedText) {
return;
}
if (selectedText !== "Non-Federal Agency") {
if (organizationType.value !== "federal") { if (organizationType.value !== "federal") {
organizationType.value = "federal"; organizationType.value = "federal";
} }
}else if (selectedText === "Non-Federal Agency" && organizationType.value === "federal") { }else {
organizationType.value = ""; if (organizationType.value === "federal") {
} organizationType.value = "";
}
// There isn't a federal senior official associated with null records and non federal agencies
if (!selectedText || selectedText === "Non-Federal Agency") {
return;
} }
// Get the associated senior official with this federal agency // Get the associated senior official with this federal agency
@ -823,7 +825,7 @@ function initializeWidgetOnList(list, parentId) {
return; return;
} }
let seniorOfficialApi = document.querySelector("#senior_official_from_agency_json_url").value; let seniorOfficialApi = document.getElementById("senior_official_from_agency_json_url").value;
fetch(`${seniorOfficialApi}?agency_name=${selectedText}`) fetch(`${seniorOfficialApi}?agency_name=${selectedText}`)
.then(response => { .then(response => {
const statusCode = response.status; const statusCode = response.status;
@ -834,8 +836,10 @@ function initializeWidgetOnList(list, parentId) {
// Clear the field if the SO doesn't exist. // Clear the field if the SO doesn't exist.
if (statusCode === 404) { if (statusCode === 404) {
$seniorOfficial.val("").trigger("change"); $seniorOfficial.val("").trigger("change");
console.warn("Record not found: " + data.error);
}else {
console.error("Error in AJAX call: " + data.error);
} }
console.error("Error in AJAX call: " + data.error);
return; return;
} }