zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-31 06:56:33 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug with load senior official table

Browse source
This commit is contained in:
zandercymatics 2024-08-09 10:09:17 -06:00
parent a9a93df5cd
commit 3837359977
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/registrar/management/commands/load_senior_official_table.py
View file

@ -35,7 +35,6 @@ class Command(BaseCommand):
Note: Note:
- If the row is missing SO data - it will not be added. - If the row is missing SO data - it will not be added.
- Given we can add the row, any blank first_name will be replaced with "-".
""", # noqa: W291 """, # noqa: W291
prompt_title="Do you wish to load records into the SeniorOfficial table?", prompt_title="Do you wish to load records into the SeniorOfficial table?",
) )
@ -64,7 +63,11 @@ class Command(BaseCommand):
# Clean the returned data # Clean the returned data
for key, value in so_kwargs.items(): for key, value in so_kwargs.items():
if isinstance(value, str): if isinstance(value, str):
so_kwargs[key] = value.strip() clean_string = value.strip()
if clean_string:
so_kwargs[key] = clean_string
else:
so_kwargs[key] = None
# Handle the federal_agency record seperately (db call) # Handle the federal_agency record seperately (db call)
agency_name = row.get("Agency").strip() if row.get("Agency") else None agency_name = row.get("Agency").strip() if row.get("Agency") else None
@ -95,17 +98,11 @@ class Command(BaseCommand):
def create_senior_official(self, so_kwargs): def create_senior_official(self, so_kwargs):
"""Creates a senior official object from kwargs but does not add it to the DB""" """Creates a senior official object from kwargs but does not add it to the DB"""
# WORKAROUND: Placeholder value for first name,
# as not having these makes it impossible to access through DJA.
old_first_name = so_kwargs["first_name"]
if not so_kwargs["first_name"]:
so_kwargs["first_name"] = "-"
# Create a new SeniorOfficial object # Create a new SeniorOfficial object
new_so = SeniorOfficial(**so_kwargs) new_so = SeniorOfficial(**so_kwargs)
# Store a variable for the console logger # Store a variable for the console logger
if all([old_first_name, new_so.last_name]): if all([new_so.first_name, new_so.last_name]):
record_display = new_so record_display = new_so
else: else:
record_display = so_kwargs record_display = so_kwargs